You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
virt/web/tests/CloudInstanceReadPerformanc...

107 lines
5.7 KiB
PHTML

<?php
// Static regression checks for the instance read path. These protect the two
// performance properties that are also security boundaries: list inventory is
// fetched once per visible host and engine rows are intersected with the
// actor-scoped database UUID set; detail pages never refresh the full list.
$root = dirname(__DIR__);
$assert = static function ($condition, string $message): void {
if (!$condition) {
throw new RuntimeException($message);
}
};
$section = static function (string $source, string $start, string $end): string {
$offset = strpos($source, $start);
if ($offset === false) {
return '';
}
$limit = strpos($source, $end, $offset + strlen($start));
return $limit === false ? substr($source, $offset)
: substr($source, $offset, $limit - $offset);
};
$controller = file_get_contents($root . '/app/Controllers/CloudApiController.php');
$runtime = file_get_contents($root . '/public/cloud/runtime.js');
$detail = file_get_contents($root . '/public/cloud/detail.js');
$instances = file_get_contents($root . '/public/cloud/instances.js');
$detailTemplate = file_get_contents(
$root . '/resources/views/venix/cloud/pages/detail.tpl'
);
$contexts = $section($controller, 'private function vmListContexts(',
'private function vmData(');
$list = $section($controller, 'public function vms(', 'public function vm(');
$detailApi = $section($controller, 'public function vm(', 'public function metrics(');
$assert(str_contains($contexts,
"groupBy(fn (\$instance) => (int) \$instance->host_id)")
&& substr_count($contexts, "->host((int) \$hostId, 'GET', 'vms', \$actor)") === 1,
'Instance inventory is not requested once per visible host.');
$assert(str_contains($contexts, 'CloudHost::whereIn')
&& str_contains($contexts, 'CloudServicePeriod::whereIn')
&& str_contains($contexts, "->groupBy('instance_id')"),
'Instance host and service-period dependencies are no longer bulk loaded.');
$assert(str_contains($contexts,
"\$allowed[strtolower((string) \$instance->uuid)] = (int) \$instance->id")
&& str_contains($contexts,
"\$instanceId = \$allowed[strtolower(trim(\$vm['uuid']))] ?? null")
&& str_contains($contexts, 'if ($instanceId !== null)'),
'Engine inventory is not strictly intersected with actor-visible database UUIDs.');
$assert(str_contains($list, '$contexts = $this->vmListContexts($instances, $actor)')
&& str_contains($list, '$contexts[(int) $instance->id] ?? []'),
'The VM list bypasses its bulk contexts and may reintroduce per-row reads.');
$assert(str_contains($detailApi,
'$this->vmData(CloudAccess::instance($args[\'id\'], $actor), $actor)'),
'The single-instance API no longer starts from the owner-scoped access check.');
$loadVm = $section($runtime, 'async function loadVm(',
'function renderVmDetail(');
$selection = $section($runtime, 'async function selectVmByApiId(',
'function bindPageCleanup(');
$assert(str_contains($loadVm, "api(`/api/v1/vms/\${encodeURIComponent(id)}`)")
&& str_contains($loadVm, 'state.vms = [vm]'),
'The detail loader does not use the single-instance API.');
$assert(str_contains($selection, 'await loadVm(apiId, true)')
&& !str_contains($selection, 'loadVms('),
'Detail selection still fetches the full VM list.');
$statusLoader = $section($runtime, 'async function loadVmStatus(',
'function renderVmDetail(');
$assert(str_contains($detail, 'hydrateVmDetailBootstrap(detailBootstrap())')
&& str_contains($detailTemplate, 'id="vm-detail-bootstrap"')
&& !str_contains($detail, 'initializeSession(')
&& !str_contains($detail, 'selectVmByApiId(')
&& str_contains($detail,
'api(`/api/v1/vms/${encodeURIComponent(vmId)}/metadata`)')
&& str_contains($detail, 'loadVmMetadata(vmId, forceMetadata).catch(')
&& str_contains($detail, 'loadVmStatus(vmId)')
&& str_contains($detail,
'if (!force && !needsVmMetadata(selectedVm())) return selectedVm();')
&& str_contains($detail, 'refreshMetadataAndStatus(vmId, true, true)')
&& str_contains($detail, 'await Promise.all([')
&& str_contains($detail, 'Object.prototype.hasOwnProperty.call(update, field)')
&& !str_contains($detail, 'loadVm('),
'Detail must keep SSR first paint, then safely merge one metadata response before status polling.');
$assert(str_contains($statusLoader,
'api(`/api/v1/vms/${encodeURIComponent(id)}/status`)')
&& str_contains($statusLoader, 'const current = selectedVm()')
&& substr_count($detail, 'loadVmStatus(vmId)') >= 4
&& str_contains($detail, 'window.setTimeout(poll, 20000)')
&& !str_contains($detail, 'setInterval(')
&& !str_contains($detail, 'loadVms'),
'Detail refresh and non-overlapping polling must use only the lightweight status endpoint.');
$assert(str_contains($instances,
'api(`/api/v1/vms/metadata?ids=${encodeURIComponent(ids.join(\',\'))}`)')
&& str_contains($instances, 'async function refreshMetadata()')
&& str_contains($instances, 'state.vms.filter(needsVmMetadata)')
&& str_contains($instances, 'if (state.loading || state.metadataLoading) return;')
&& str_contains($instances,
'const busy = state.loading || state.metadataLoading || state.statusLoading;')
&& substr_count($instances,
'await Promise.all([refreshMetadata(), refreshStatuses(true)]);') === 2
&& str_contains($instances, 'async function refreshStatuses(')
&& str_contains($instances, 'Object.prototype.hasOwnProperty.call(update, field)')
&& !str_contains($instances, "api('/api/v1/vms')"),
'Each instance page must fetch only its static metadata once, then retain lightweight status polling.');
echo "Cloud instance bulk-list and single-detail read paths passed.\n";