|
|
|
|
@ -25,6 +25,34 @@ func (l *Libvirt) CreateBackup(ctx context.Context, uuid string, request BackupR
|
|
|
|
|
return l.createPortableBackup(ctx, uuid, request)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// GetBackupReadiness reports only transient blockers which automatic backup
|
|
|
|
|
// may safely defer. It deliberately does not reserve resources or consume
|
|
|
|
|
// retained job evidence, and CreateBackup repeats these checks before mutation.
|
|
|
|
|
func (l *Libvirt) GetBackupReadiness(ctx context.Context, uuid string) (BackupReadiness, error) {
|
|
|
|
|
domain, err := l.domainByUUID(ctx, uuid)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return BackupReadiness{}, err
|
|
|
|
|
}
|
|
|
|
|
defer domain.Free()
|
|
|
|
|
_, metadata, err := requireManagedDomain(domain)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return BackupReadiness{}, err
|
|
|
|
|
}
|
|
|
|
|
if reason := backupTransientBlocker(metadata); reason != "" {
|
|
|
|
|
return BackupReadiness{Eligible: false, Retryable: true, Reason: reason}, nil
|
|
|
|
|
}
|
|
|
|
|
if err := ensureNoActiveDomainJobIfRunning(domain); err != nil {
|
|
|
|
|
var public interface{ PublicCode() string }
|
|
|
|
|
if errors.As(err, &public) && public.PublicCode() == "domain_job_active" {
|
|
|
|
|
return BackupReadiness{
|
|
|
|
|
Eligible: false, Retryable: true, Reason: "domain_job_active",
|
|
|
|
|
}, nil
|
|
|
|
|
}
|
|
|
|
|
return BackupReadiness{}, err
|
|
|
|
|
}
|
|
|
|
|
return BackupReadiness{Eligible: true, Retryable: false}, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (l *Libvirt) createPortableBackup(ctx context.Context, uuid string, request BackupRequest) (_ BackupResult, resultErr error) {
|
|
|
|
|
client := objecttransfer.New()
|
|
|
|
|
defer client.CloseIdleConnections()
|
|
|
|
|
@ -275,10 +303,7 @@ func (l *Libvirt) validateBackupSource(ctx context.Context, uuid, backupKey stri
|
|
|
|
|
}
|
|
|
|
|
defer pool.Free()
|
|
|
|
|
defer volume.Free()
|
|
|
|
|
if metadata.RescueTemplateID != "" {
|
|
|
|
|
return false, PortableRestoreContract{}, NewError(ErrConflict, "backup_rescue_active", "VM backup is unavailable while rescue media is attached", nil)
|
|
|
|
|
}
|
|
|
|
|
if err := validateBackupTransitionState(metadata); err != nil {
|
|
|
|
|
if err := validateBackupTransientState(metadata); err != nil {
|
|
|
|
|
return false, PortableRestoreContract{}, err
|
|
|
|
|
}
|
|
|
|
|
for _, stored := range metadata.Snapshots {
|
|
|
|
|
@ -404,17 +429,34 @@ func portableQ35Machine(machine string) bool {
|
|
|
|
|
return machine == "q35" || strings.HasPrefix(machine, "pc-q35-")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func validateBackupTransitionState(metadata *domainMetadataXML) error {
|
|
|
|
|
func backupTransientBlocker(metadata *domainMetadataXML) string {
|
|
|
|
|
if metadata != nil && metadata.RescueTemplateID != "" {
|
|
|
|
|
return "backup_rescue_active"
|
|
|
|
|
}
|
|
|
|
|
// Reinstall and snapshot restore deliberately retain their transition kind
|
|
|
|
|
// and operation ID after the old root has been deleted. Those markers prove
|
|
|
|
|
// a completed root switch during reconciliation; only a pending old root
|
|
|
|
|
// means that the disk transition is still active.
|
|
|
|
|
if metadata != nil && metadata.PendingCleanupVolume != "" {
|
|
|
|
|
return "backup_disk_transition_active"
|
|
|
|
|
}
|
|
|
|
|
return ""
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func validateBackupTransientState(metadata *domainMetadataXML) error {
|
|
|
|
|
switch backupTransientBlocker(metadata) {
|
|
|
|
|
case "backup_rescue_active":
|
|
|
|
|
return NewError(ErrConflict, "backup_rescue_active", "VM backup is unavailable while rescue media is attached", nil)
|
|
|
|
|
case "backup_disk_transition_active":
|
|
|
|
|
return NewError(ErrConflict, "backup_disk_transition_active", "VM backup is unavailable during a disk transition", nil)
|
|
|
|
|
}
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func validateBackupTransitionState(metadata *domainMetadataXML) error {
|
|
|
|
|
return validateBackupTransientState(metadata)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func validateSingleWritableRoot(definition *libvirtxml.Domain) error {
|
|
|
|
|
if definition == nil || definition.Devices == nil {
|
|
|
|
|
return NewError(ErrConflict, "backup_disk_layout_unsupported", "VM disk layout is unavailable for portable backup", nil)
|
|
|
|
|
|