diff --git a/web/app/Controllers/Admin/TicketController.php b/web/app/Controllers/Admin/TicketController.php index 36453f51..81db6aa3 100644 --- a/web/app/Controllers/Admin/TicketController.php +++ b/web/app/Controllers/Admin/TicketController.php @@ -19,6 +19,7 @@ use App\Services\Ticket\TicketIdempotencyConflict; use App\Services\Ticket\TicketReadModel; use App\Services\Ticket\TicketThreadQuery; use App\Services\Ticket\TicketViewer; +use App\Services\Ticket\TicketReadCommand; use App\Utils\SafeDatatables as Datatables; use App\Utils\DatatablesHelper; @@ -45,7 +46,8 @@ class TicketController extends AdminController ->assign('telegram_bound', $telegram['binding']['bound']) ->assign('telegram_admin_id', $telegram['binding']['admin_id']); } - return $view->display('admin/ticket/index.tpl'); + return $view->assign('ticket_can_search_user', AdminPermission::isSuperAdmin()) + ->display('admin/ticket/index.tpl'); } private function telegramViewState(): array @@ -181,24 +183,40 @@ class TicketController extends AdminController return $this->streamTicketAttachment($response, $attachment); } + public function markRead($request, $response, $args) + { + if (!AdminCsrf::verify($request)) { + return $this->echoJson($response, ['ret' => 0, 'msg' => '请求已过期,请刷新页面后重试']); + } + $marked = (new TicketReadModel())->markRead( + new TicketReadCommand((int) ($args['id'] ?? 0)), + TicketViewer::administrator( + (int) Auth::getUser()->id, + AdminPermission::isSuperAdmin() + ) + ); + if (!$marked) { + return $response->withStatus(404); + } + return $this->echoJson($response, ['ret' => 1]); + } + public function ajax($request, $response, $args) { $datatables = new Datatables(new DatatablesHelper()); - $connection = (new Ticket())->getConnection(); - $schema = $connection->getSchemaBuilder(); - $ticketType = $this->ticketColumnExpression($schema, 'ticket_type', "'technical'"); - $priority = $this->ticketColumnExpression($schema, 'priority', "'medium'"); - $instanceId = $this->ticketColumnExpression($schema, 'instance_id', 'NULL'); + $adminId = (int) Auth::getUser()->id; $datatables->query('SELECT ticket.id AS op,ticket.id,' - . 'CASE WHEN ticket_activity.last_reply_at IS NULL ' - . 'OR ticket_activity.last_reply_at < ticket.datetime ' - . 'THEN ticket.datetime ELSE ticket_activity.last_reply_at END AS datetime,' + . 'ticket.last_activity_at AS datetime,' . 'ticket.title,ticket.userid,user.user_name,' - . $ticketType . ' AS ticket_type,' . $priority . ' AS priority,' . $instanceId - . ' AS instance_id,ticket.status FROM ticket ' + . 'ticket.ticket_type,ticket.priority,ticket.instance_id,ticket.status,' + . 'CASE WHEN COALESCE(ticket_reader.last_read_message_id,0) ' + . '< ticket.last_message_id THEN 1 ELSE 0 END AS unread,' + . "CASE WHEN ticket.status=0 THEN 'closed' " + . "WHEN ticket.last_actor_is_admin=1 THEN 'user' ELSE 'admin' END AS waiting_for " + . 'FROM ticket ' . 'INNER JOIN user ON ticket.userid = user.id ' - . 'LEFT JOIN (SELECT rootid, MAX(datetime) AS last_reply_at FROM ticket ' - . 'WHERE rootid <> 0 GROUP BY rootid) AS ticket_activity ON ticket_activity.rootid = ticket.id ' + . 'LEFT JOIN ticket_read_states AS ticket_reader ' + . 'ON ticket_reader.ticket_id=ticket.id AND ticket_reader.reader_id=' . $adminId . ' ' . 'WHERE ticket.rootid = 0'); $datatables->edit('op', function ($data) { @@ -221,6 +239,14 @@ class TicketController extends AdminController return $data['status'] == 1 ? '开启' : '关闭'; }); + $datatables->edit('waiting_for', function ($data) { + return match ((string) $data['waiting_for']) { + 'admin' => '等待管理员', + 'user' => '等待用户', + default => '已关闭', + }; + }); + $statusTotals = Ticket::where('rootid', 0) ->selectRaw('COUNT(*) AS total') ->selectRaw('SUM(CASE WHEN status = 1 THEN 1 ELSE 0 END) AS open_count') @@ -239,12 +265,4 @@ class TicketController extends AdminController return $response->withHeader('Content-Type', 'application/json; charset=utf-8'); } - private function ticketColumnExpression($schema, string $column, string $fallback): string - { - try { - return $schema->hasColumn('ticket', $column) ? 'ticket.' . $column : $fallback; - } catch (\Throwable $exception) { - return $fallback; - } - } } diff --git a/web/app/Controllers/UserController.php b/web/app/Controllers/UserController.php index d34ed2b1..734c4c97 100644 --- a/web/app/Controllers/UserController.php +++ b/web/app/Controllers/UserController.php @@ -40,6 +40,7 @@ use App\Services\Ticket\TicketQueueQuery; use App\Services\Ticket\TicketReadModel; use App\Services\Ticket\TicketThreadQuery; use App\Services\Ticket\TicketViewer; +use App\Services\Ticket\TicketReadCommand; use App\Services\UserDrawerService; /** @@ -767,6 +768,25 @@ class UserController extends BaseController return $this->streamTicketAttachment($response, $attachment); } + public function ticket_mark_read($request, $response, $args) + { + if (!AdminCsrf::verify($request)) { + return $this->echoJson($response, ['ret' => 0, 'msg' => '请求已过期,请刷新页面后重试']); + } + try { + $marked = (new TicketReadModel())->markRead( + new TicketReadCommand((int) ($args['id'] ?? 0)), + TicketViewer::user((int) $this->user->id) + ); + } catch (\Throwable $exception) { + $marked = false; + } + if (!$marked) { + return $response->withStatus(404); + } + return $this->echoJson($response, ['ret' => 1]); + } + private function ticketInstances(): array { try { diff --git a/web/app/Services/Ticket/TicketReadCommand.php b/web/app/Services/Ticket/TicketReadCommand.php new file mode 100644 index 00000000..154595de --- /dev/null +++ b/web/app/Services/Ticket/TicketReadCommand.php @@ -0,0 +1,13 @@ +ticketId < 1) { + throw new \InvalidArgumentException('工单编号无效'); + } + } +} diff --git a/web/app/Services/Ticket/TicketReadModel.php b/web/app/Services/Ticket/TicketReadModel.php index d2d2561c..0771717c 100644 --- a/web/app/Services/Ticket/TicketReadModel.php +++ b/web/app/Services/Ticket/TicketReadModel.php @@ -21,9 +21,9 @@ final class TicketReadModel */ public function queue(TicketQueueQuery $query, TicketViewer $viewer): array { - $roots = Ticket::where('rootid', 0); + $roots = Ticket::where('ticket.rootid', 0); if (!$viewer->isAdmin) { - $roots->where('userid', $viewer->actorId); + $roots->where('ticket.userid', $viewer->actorId); } $counts = (clone $roots) @@ -31,10 +31,16 @@ final class TicketReadModel ->selectRaw('SUM(CASE WHEN status = 0 THEN 1 ELSE 0 END) AS closed_count') ->first(); $tickets = $roots - ->selectRaw('ticket.*, COALESCE((SELECT MAX(ticket_replies.datetime) ' - . 'FROM ticket AS ticket_replies WHERE ticket_replies.rootid = ticket.id), ' - . 'ticket.datetime) AS last_activity_at') - ->orderByDesc('last_activity_at')->orderByDesc('id') + ->leftJoin('ticket_read_states AS ticket_reader', function ($join) use ($viewer): void { + $join->on('ticket_reader.ticket_id', '=', 'ticket.id') + ->where('ticket_reader.reader_id', '=', $viewer->actorId); + }) + ->select('ticket.*') + ->selectRaw('CASE WHEN COALESCE(ticket_reader.last_read_message_id, 0) ' + . '< ticket.last_message_id THEN 1 ELSE 0 END AS is_unread') + ->selectRaw("CASE WHEN ticket.status = 0 THEN 'closed' " + . "WHEN ticket.last_actor_is_admin = 1 THEN 'user' ELSE 'admin' END AS waiting_for") + ->orderByDesc('ticket.last_activity_at')->orderByDesc('ticket.id') ->paginate($query->perPage, ['*'], 'page', $query->page); return [ @@ -125,6 +131,24 @@ final class TicketReadModel return ['root' => $root, 'title' => $title, 'messages' => $messages]; } + public function markRead(TicketReadCommand $command, TicketViewer $viewer): bool + { + $query = Ticket::where('id', $command->ticketId)->where('rootid', 0); + if (!$viewer->isAdmin) { + $query->where('userid', $viewer->actorId); + } + $root = $query->first(); + if ($root === null) { + return false; + } + $lastMessageId = max((int) $root->id, (int) $root->last_message_id); + (new Ticket())->getConnection()->table('ticket_read_states')->updateOrInsert( + ['ticket_id' => (int) $root->id, 'reader_id' => $viewer->actorId], + ['last_read_message_id' => $lastMessageId, 'read_at' => time()] + ); + return true; + } + private function authorName($author, bool $authorIsAdmin, TicketViewer $viewer): string { if ($author === null) { diff --git a/web/app/Services/Ticket/TicketThreadService.php b/web/app/Services/Ticket/TicketThreadService.php index 64ca5bc5..4aebf5ca 100644 --- a/web/app/Services/Ticket/TicketThreadService.php +++ b/web/app/Services/Ticket/TicketThreadService.php @@ -76,9 +76,17 @@ final class TicketThreadService $ticket->ticket_type = $type; $ticket->priority = $priority; $ticket->instance_id = $instanceId; + $ticket->last_activity_at = (int) $ticket->datetime; + $ticket->last_message_id = 0; + $ticket->last_actor_id = $command->actorId; + $ticket->last_actor_is_admin = 0; if (!$ticket->save()) { throw new \RuntimeException('工单保存失败'); } + $ticket->last_message_id = (int) $ticket->id; + if (!$ticket->save()) { + throw new \RuntimeException('工单活动投影保存失败'); + } $attachments = TicketAttachmentService::store( $command->request, (int) $ticket->id, @@ -86,6 +94,7 @@ final class TicketThreadService $command->actorId, $createdPaths ); + $this->advanceReadState((int) $ticket->id, $command->actorId, (int) $ticket->id); $this->completeIntent($intent, (int) $ticket->id, (int) $ticket->id); return new TicketWriteResult($ticket, $ticket, '新工单', $attachments); }, 1); @@ -160,10 +169,17 @@ final class TicketThreadService $reply->priority = (string) $root->priority; $reply->instance_id = $root->instance_id; - $root->status = $command->status; - if (!$root->save() || !$reply->save()) { + if (!$reply->save()) { throw new \RuntimeException('工单回复保存失败'); } + $root->status = $command->status; + $root->last_activity_at = (int) $reply->datetime; + $root->last_message_id = (int) $reply->id; + $root->last_actor_id = $command->actorId; + $root->last_actor_is_admin = $command->actorIsAdmin ? 1 : 0; + if (!$root->save()) { + throw new \RuntimeException('工单活动投影保存失败'); + } $attachments = TicketAttachmentService::store( $command->request, (int) $root->id, @@ -171,6 +187,11 @@ final class TicketThreadService $command->actorId, $createdPaths ); + $this->advanceReadState( + (int) $root->id, + $command->actorId, + (int) $reply->id + ); $this->completeIntent($intent, (int) $root->id, (int) $reply->id); return new TicketWriteResult($root, $reply, $event, $attachments); }, 1); @@ -256,6 +277,14 @@ final class TicketThreadService } } + private function advanceReadState(int $ticketId, int $readerId, int $messageId): void + { + (new Ticket())->getConnection()->table('ticket_read_states')->updateOrInsert( + ['ticket_id' => $ticketId, 'reader_id' => $readerId], + ['last_read_message_id' => $messageId, 'read_at' => time()] + ); + } + private function replayResult(TicketWriteRequest $intent, string $event): TicketWriteResult { $root = Ticket::where('id', (int) $intent->ticket_id)->where('rootid', 0)->first(); diff --git a/web/config/routes.php b/web/config/routes.php index 27ecf8ee..5a35447a 100644 --- a/web/config/routes.php +++ b/web/config/routes.php @@ -111,6 +111,7 @@ $app->group('/user', function () { $this->post('/ticket', 'App\Controllers\UserController:ticket_add'); $this->get('/ticket/{id}/view', 'App\Controllers\UserController:ticket_view'); $this->get('/ticket/{id}/attachment/{attachment_id:[0-9]+}', 'App\Controllers\UserController:ticket_attachment'); + $this->post('/ticket/{id}/read', 'App\Controllers\UserController:ticket_mark_read'); // Multipart replies use POST so PHP reliably exposes uploaded files in // $_FILES; the legacy PUT endpoint remains available for text clients. $this->post('/ticket/{id}/reply', 'App\Controllers\UserController:ticket_update'); @@ -205,6 +206,7 @@ $app->group('/admin', function () { $this->get('/ticket', 'App\Controllers\Admin\TicketController:index'); $this->get('/ticket/{id}/view', 'App\Controllers\Admin\TicketController:show'); $this->get('/ticket/{id}/attachment/{attachment_id:[0-9]+}', 'App\Controllers\Admin\TicketController:attachment')->add(new SuperAdmin()); + $this->post('/ticket/{id}/read', 'App\Controllers\Admin\TicketController:markRead'); // Keep multipart administrator replies on POST for PHP upload parsing; // existing PUT clients continue to use the original endpoint. $this->post('/ticket/{id}/reply', 'App\Controllers\Admin\TicketController:update')->add(new SuperAdmin()); diff --git a/web/public/theme/venix/js/ticket-page.js b/web/public/theme/venix/js/ticket-page.js index 741ae941..84858552 100644 --- a/web/public/theme/venix/js/ticket-page.js +++ b/web/public/theme/venix/js/ticket-page.js @@ -351,8 +351,24 @@ }); } + function markThreadRead() { + var form = qs("#supportTicketReply"); + var ticketId; + if (!form) return; + ticketId = form.getAttribute("data-ticket-id"); + if (!ticketId) return; + fetch("/user/ticket/" + encodeURIComponent(ticketId) + "/read", { + method: "POST", + credentials: "same-origin", + headers: Object.assign({ "X-Requested-With": "XMLHttpRequest" }, csrfHeaders()) + }).catch(function () { + /* Reading the thread remains useful even when acknowledgement is delayed. */ + }); + } + document.addEventListener("DOMContentLoaded", function () { bindCreate(); bindReply(); + markThreadRead(); }); })(); diff --git a/web/resources/views/venix/admin/ticket/index.tpl b/web/resources/views/venix/admin/ticket/index.tpl index 61a682d3..4273b6b6 100644 --- a/web/resources/views/venix/admin/ticket/index.tpl +++ b/web/resources/views/venix/admin/ticket/index.tpl @@ -65,7 +65,7 @@
- +
@@ -130,6 +130,7 @@ var recordsFiltered = 0; var requestSerial = 0; var searchTimer = null; + var canSearchUser = search.getAttribute('data-can-search-user') === '1'; if (window.VenixAdminSearchState) { window.VenixAdminSearchState.bind(search); @@ -162,7 +163,9 @@ ticket_type: item.ticket_type || item[6] || 'technical', priority: item.priority || item[7] || 'medium', instance_id: item.instance_id || item[8] || '', - status: item.status || item[9] || '' + status: item.status || item[9] || '', + unread: item.unread || item[10] || 0, + waiting_for: item.waiting_for || item[11] || '' }; } @@ -192,13 +195,13 @@ var openStatus = isOpen(item); tr.innerHTML = '#' + escapeHtml(item.id) + '' + - '
' + escapeHtml(item.title || '-') + '
' + + '
' + (Number(item.unread) ? '新' : '') + escapeHtml(item.title || '-') + '
' + '
' + escapeHtml(item.user_name || '未知用户') + 'ID ' + escapeHtml(item.userid || '-') + '
' + '' + (item.ticket_type === 'pre_sales' ? '售前' : (item.ticket_type === 'after_sales' ? '售后' : (item.ticket_type === 'finance' ? '财务' : '技术'))) + '' + '' + (item.priority === 'high' ? 'High' : (item.priority === 'low' ? 'Low' : 'Medium')) + '' + '' + (item.instance_id ? '#' + escapeHtml(item.instance_id) : '—') + '' + '' + escapeHtml(item.datetime || '-') + '' + - '' + (openStatus ? '待处理' : '已关闭') + '' + + '' + (openStatus ? escapeHtml(item.waiting_for || '待处理') : '已关闭') + '' + '查看'; rows.appendChild(tr); }); @@ -212,10 +215,10 @@ params.set('search[value]', search.value.trim()); params.set('order[0][column]', '2'); params.set('order[0][dir]', 'desc'); - ['op', 'id', 'datetime', 'title', 'userid', 'user_name', 'ticket_type', 'priority', 'instance_id', 'status'].forEach(function (column, index) { + ['op', 'id', 'datetime', 'title', 'userid', 'user_name', 'ticket_type', 'priority', 'instance_id', 'status', 'unread', 'waiting_for'].forEach(function (column, index) { params.set('columns[' + index + '][data]', column); params.set('columns[' + index + '][name]', ''); - params.set('columns[' + index + '][searchable]', 'true'); + params.set('columns[' + index + '][searchable]', column === 'user_name' ? (canSearchUser ? 'true' : 'false') : (column === 'unread' || column === 'waiting_for' ? 'false' : 'true')); params.set('columns[' + index + '][orderable]', 'true'); params.set('columns[' + index + '][search][value]', column === 'status' ? (filter === 'open' ? '1' : (filter === 'closed' ? '0' : '')) diff --git a/web/resources/views/venix/admin/ticket/view.tpl b/web/resources/views/venix/admin/ticket/view.tpl index 09a734e7..f749635a 100644 --- a/web/resources/views/venix/admin/ticket/view.tpl +++ b/web/resources/views/venix/admin/ticket/view.tpl @@ -17,7 +17,7 @@

REPLY

回复工单
{if !$ticket_can_manage}

当前为只读模式,仅超级管理员可以回复或关闭工单。

{/if} -
+
最多 5 张,每张不超过 5 MB。
@@ -47,12 +47,13 @@ {literal} {/literal} diff --git a/web/resources/views/venix/user/ticket.tpl b/web/resources/views/venix/user/ticket.tpl index be695d40..e1f8c452 100755 --- a/web/resources/views/venix/user/ticket.tpl +++ b/web/resources/views/venix/user/ticket.tpl @@ -45,6 +45,7 @@
#{$ticket->id} + {if $ticket->is_unread|default:0}新消息{/if} {if $ticket->ticket_type|default:'' == 'pre_sales'}售前 {elseif $ticket->ticket_type|default:'' == 'after_sales'}售后 {elseif $ticket->ticket_type|default:'' == 'finance'}财务 @@ -54,7 +55,7 @@ {elseif $ticket->priority|default:'' == 'low'}低优先级{/if}

{$ticket->title|escape:"html"}

-

最近活动 {$ticket->lastActivity()}

+

最近活动 {$ticket->lastActivity()} · {if $ticket->waiting_for|default:''=='admin'}等待管理员{elseif $ticket->waiting_for|default:''=='user'}等待你回复{else}已关闭{/if}

diff --git a/web/tests/AdminTicketQueueContractTest.php b/web/tests/AdminTicketQueueContractTest.php index 3f2a823f..15487824 100644 --- a/web/tests/AdminTicketQueueContractTest.php +++ b/web/tests/AdminTicketQueueContractTest.php @@ -30,16 +30,18 @@ $assert( 'The administrator ticket page must project filtered totals into paging controls.' ); $assert( - str_contains($controller, 'last_reply_at') + str_contains($controller, 'ticket.last_activity_at AS datetime') + && !str_contains($controller, 'MAX(datetime) AS last_reply_at') && str_contains($controller, "'statusTotals'") && str_contains($controller, 'generate(false)'), - 'The ticket API must expose recent activity and complete status totals.' + 'The ticket API must use the durable activity projection and complete status totals.' ); $assert( str_contains($userController, 'TicketReadModel') - && str_contains($readModel, 'last_activity_at') + && str_contains($readModel, "orderByDesc('ticket.last_activity_at')") + && str_contains($readModel, 'ticket_reader.last_read_message_id') && str_contains($readModel, 'orderByDesc'), - 'The user ticket queue must use the same recent-activity ordering contract.' + 'The user ticket queue must use durable recent activity and per-reader state.' ); $assert( str_contains($schema, 'ticket_activity_root_datetime'), diff --git a/web/tests/TicketIdempotencyTest.php b/web/tests/TicketIdempotencyTest.php index d8f54786..f4d429b9 100644 --- a/web/tests/TicketIdempotencyTest.php +++ b/web/tests/TicketIdempotencyTest.php @@ -39,6 +39,10 @@ $schema->create('ticket', static function (Blueprint $table): void { $table->string('ticket_type')->default('technical'); $table->string('priority')->default('medium'); $table->integer('instance_id')->nullable(); + $table->integer('last_activity_at')->default(0); + $table->integer('last_message_id')->default(0); + $table->integer('last_actor_id')->default(0); + $table->boolean('last_actor_is_admin')->default(false); }); $schema->create('ticket_attachments', static function (Blueprint $table): void { $table->increments('id'); @@ -67,6 +71,11 @@ $schema->create('ticket_user_guards', static function (Blueprint $table): void { $table->integer('user_id')->primary(); $table->integer('updated_at'); }); +$schema->create('ticket_read_states', static function (Blueprint $table): void { + $table->integer('ticket_id'); $table->integer('reader_id'); + $table->integer('last_read_message_id'); $table->integer('read_at'); + $table->primary(['ticket_id', 'reader_id']); +}); $schema->create('cloud_instances', static function (Blueprint $table): void { $table->increments('id'); $table->integer('user_id'); diff --git a/web/tests/TicketReadStateTest.php b/web/tests/TicketReadStateTest.php new file mode 100644 index 00000000..ef3cbe5e --- /dev/null +++ b/web/tests/TicketReadStateTest.php @@ -0,0 +1,101 @@ +addConnection(['driver' => 'sqlite', 'database' => ':memory:'], 'default'); +$capsule->setAsGlobal(); +$capsule->bootEloquent(); +$schema = $capsule->getConnection('default')->getSchemaBuilder(); +$schema->create('user', static function (Blueprint $table): void { + $table->increments('id'); $table->string('user_name'); $table->boolean('is_admin'); +}); +$schema->create('ticket', static function (Blueprint $table): void { + $table->increments('id'); $table->text('title'); $table->text('content'); + $table->integer('rootid'); $table->integer('userid'); $table->integer('datetime'); + $table->integer('status'); $table->string('ticket_type'); $table->string('priority'); + $table->integer('instance_id')->nullable(); $table->integer('last_activity_at'); + $table->integer('last_message_id'); $table->integer('last_actor_id'); + $table->boolean('last_actor_is_admin'); +}); +$schema->create('ticket_attachments', static function (Blueprint $table): void { + $table->increments('id'); $table->integer('ticket_id'); $table->integer('message_id'); + $table->integer('user_id'); $table->string('storage_key'); $table->string('original_name'); + $table->string('mime_type'); $table->integer('bytes'); $table->string('sha256'); + $table->integer('created_at'); +}); +$schema->create('ticket_read_states', static function (Blueprint $table): void { + $table->integer('ticket_id'); $table->integer('reader_id'); + $table->integer('last_read_message_id'); $table->integer('read_at'); + $table->primary(['ticket_id', 'reader_id']); +}); +Capsule::table('user')->insert([ + ['id' => 7, 'user_name' => 'owner', 'is_admin' => 0], + ['id' => 9, 'user_name' => 'admin-one', 'is_admin' => 1], + ['id' => 10, 'user_name' => 'admin-two', 'is_admin' => 1], +]); +Capsule::table('ticket')->insert([ + ['id' => 1, 'title' => 'Help', 'content' => 'root', 'rootid' => 0, 'userid' => 7, + 'datetime' => 100, 'status' => 1, 'ticket_type' => 'technical', 'priority' => 'medium', + 'instance_id' => null, 'last_activity_at' => 120, 'last_message_id' => 3, + 'last_actor_id' => 7, 'last_actor_is_admin' => 0], + ['id' => 2, 'title' => 'Help', 'content' => 'admin', 'rootid' => 1, 'userid' => 9, + 'datetime' => 110, 'status' => 1, 'ticket_type' => 'technical', 'priority' => 'medium', + 'instance_id' => null, 'last_activity_at' => 0, 'last_message_id' => 0, + 'last_actor_id' => 0, 'last_actor_is_admin' => 0], + ['id' => 3, 'title' => 'Help', 'content' => 'owner', 'rootid' => 1, 'userid' => 7, + 'datetime' => 120, 'status' => 1, 'ticket_type' => 'technical', 'priority' => 'medium', + 'instance_id' => null, 'last_activity_at' => 0, 'last_message_id' => 0, + 'last_actor_id' => 0, 'last_actor_is_admin' => 0], +]); +Capsule::table('ticket_read_states')->insert([ + ['ticket_id' => 1, 'reader_id' => 7, 'last_read_message_id' => 3, 'read_at' => 120], + ['ticket_id' => 1, 'reader_id' => 9, 'last_read_message_id' => 2, 'read_at' => 110], +]); + +$model = new TicketReadModel(); +$adminOne = TicketViewer::administrator(9, true); +$adminTwo = TicketViewer::administrator(10, true); +$queueOne = $model->queue(new TicketQueueQuery(), $adminOne)['tickets']->items(); +$queueTwo = $model->queue(new TicketQueueQuery(), $adminTwo)['tickets']->items(); +$assert((int) $queueOne[0]->is_unread === 1 && (int) $queueTwo[0]->is_unread === 1, + 'Independent administrators did not receive their own unread state.'); + +$model->thread(new TicketThreadQuery(1), $adminOne); +$assert((int) Capsule::table('ticket_read_states')->where('ticket_id', 1) + ->where('reader_id', 9)->value('last_read_message_id') === 2, + 'Reading a GET projection mutated the administrator read cursor.'); +$assert($model->markRead(new TicketReadCommand(1), $adminOne), + 'Explicit read acknowledgement failed.'); +$queueOne = $model->queue(new TicketQueueQuery(), $adminOne)['tickets']->items(); +$queueTwo = $model->queue(new TicketQueueQuery(), $adminTwo)['tickets']->items(); +$assert((int) $queueOne[0]->is_unread === 0, + 'The acknowledging administrator is still unread.'); +$assert((int) $queueTwo[0]->is_unread === 1, + 'One administrator acknowledgement cleared another administrator.'); + +$routes = file_get_contents(dirname(__DIR__) . '/config/routes.php'); +$userController = file_get_contents(dirname(__DIR__) . '/app/Controllers/UserController.php'); +$adminController = file_get_contents(dirname(__DIR__) . '/app/Controllers/Admin/TicketController.php'); +$javascript = file_get_contents(dirname(__DIR__) . '/public/theme/venix/js/ticket-page.js'); +$assert(str_contains($routes, "post('/ticket/{id}/read'") + && str_contains($userController, 'function ticket_mark_read') + && str_contains($adminController, 'function markRead'), + 'Explicit user and administrator read acknowledgement routes are incomplete.'); +$assert(str_contains($userController, 'AdminCsrf::verify($request)') + && str_contains($adminController, 'AdminCsrf::verify($request)') + && str_contains($javascript, '"/read"'), + 'Read acknowledgement is not protected by CSRF or used by the user page.'); + +echo "Ticket per-reader state checks passed.\n"; diff --git a/web/tests/TicketReplyTransactionTest.php b/web/tests/TicketReplyTransactionTest.php index cef2593b..406c6171 100644 --- a/web/tests/TicketReplyTransactionTest.php +++ b/web/tests/TicketReplyTransactionTest.php @@ -44,6 +44,10 @@ $schema->create('ticket', static function (Blueprint $table): void { $table->string('ticket_type')->default('technical'); $table->string('priority')->default('medium'); $table->integer('instance_id')->nullable(); + $table->integer('last_activity_at')->default(0); + $table->integer('last_message_id')->default(0); + $table->integer('last_actor_id')->default(0); + $table->boolean('last_actor_is_admin')->default(false); }); $schema->create('ticket_attachments', static function (Blueprint $table): void { $table->increments('id'); @@ -72,6 +76,13 @@ $schema->create('ticket_user_guards', static function (Blueprint $table): void { $table->integer('user_id')->primary(); $table->integer('updated_at'); }); +$schema->create('ticket_read_states', static function (Blueprint $table): void { + $table->integer('ticket_id'); + $table->integer('reader_id'); + $table->integer('last_read_message_id'); + $table->integer('read_at'); + $table->primary(['ticket_id', 'reader_id']); +}); $schema->create('cloud_instances', static function (Blueprint $table): void { $table->increments('id'); $table->integer('user_id'); @@ -183,6 +194,14 @@ $assert($reopened !== null && $reopened->event === '工单重新开启', 'A closed ticket did not emit the reopen event.'); $assert((int) Capsule::table('ticket')->where('id', 1)->value('status') === 1, 'The reopened ticket root is not open.'); +$projection = Capsule::table('ticket')->where('id', 1)->first(); +$assert((int) $projection->last_message_id === (int) $reopened->message->id + && (int) $projection->last_actor_id === 7 + && (int) $projection->last_actor_is_admin === 0, + 'Reply transaction did not advance the root activity projection.'); +$assert((int) Capsule::table('ticket_read_states')->where('ticket_id', 1) + ->where('reader_id', 7)->value('last_read_message_id') === (int) $reopened->message->id, + 'Reply transaction did not advance the sender read cursor.'); // The lock must be acquired in the transaction, not by a preflight query. $serviceSource = file_get_contents(dirname(__DIR__) . '/app/Services/Ticket/TicketThreadService.php'); diff --git a/web/tests/TicketUsagePolicyTest.php b/web/tests/TicketUsagePolicyTest.php index f3d3f0b6..33ce0979 100644 --- a/web/tests/TicketUsagePolicyTest.php +++ b/web/tests/TicketUsagePolicyTest.php @@ -28,6 +28,8 @@ $schema->create('ticket', static function (Blueprint $table): void { $table->integer('rootid'); $table->integer('userid'); $table->integer('datetime'); $table->integer('status'); $table->string('ticket_type'); $table->string('priority'); $table->integer('instance_id')->nullable(); + $table->integer('last_activity_at')->default(0); $table->integer('last_message_id')->default(0); + $table->integer('last_actor_id')->default(0); $table->boolean('last_actor_is_admin')->default(false); }); $schema->create('ticket_attachments', static function (Blueprint $table): void { $table->increments('id'); $table->integer('ticket_id'); $table->integer('message_id'); @@ -44,6 +46,11 @@ $schema->create('ticket_write_requests', static function (Blueprint $table): voi $schema->create('ticket_user_guards', static function (Blueprint $table): void { $table->integer('user_id')->primary(); $table->integer('updated_at'); }); +$schema->create('ticket_read_states', static function (Blueprint $table): void { + $table->integer('ticket_id'); $table->integer('reader_id'); + $table->integer('last_read_message_id'); $table->integer('read_at'); + $table->primary(['ticket_id', 'reader_id']); +}); $schema->create('cloud_instances', static function (Blueprint $table): void { $table->increments('id'); $table->integer('user_id'); $table->string('status'); });