fix(web): submit only object storage fields
parent
9ab51e1b29
commit
e9b2c8bd68
@ -0,0 +1,128 @@
|
||||
import assert from 'node:assert/strict';
|
||||
import { readFile } from 'node:fs/promises';
|
||||
import vm from 'node:vm';
|
||||
|
||||
const csrfSource = await readFile(
|
||||
new URL('../public/theme/venix/js/admin-csrf.js', import.meta.url),
|
||||
'utf8',
|
||||
);
|
||||
const template = await readFile(
|
||||
new URL('../resources/views/venix/admin/object_storage.tpl', import.meta.url),
|
||||
'utf8',
|
||||
);
|
||||
const scriptMatch = template.match(
|
||||
/\{literal\}<script>([\s\S]*?)<\/script>\{\/literal\}/,
|
||||
);
|
||||
assert.ok(scriptMatch, 'Object-storage page script was not found.');
|
||||
|
||||
class Element {
|
||||
constructor(name = '', value = '') {
|
||||
this.name = name;
|
||||
this.value = value;
|
||||
this.dataset = {};
|
||||
this.disabled = false;
|
||||
this.listeners = new Map();
|
||||
this.textContent = '';
|
||||
this.className = '';
|
||||
}
|
||||
|
||||
addEventListener(name, listener) {
|
||||
this.listeners.set(name, listener);
|
||||
}
|
||||
}
|
||||
|
||||
const fields = [
|
||||
new Element('expected_revision', '4'),
|
||||
new Element('name', 'Vultr Object Storage'),
|
||||
new Element('endpoint', 'https://ewr1.vultrobjects.com'),
|
||||
new Element('region', 'us-east-1'),
|
||||
new Element('bucket', 'virt-backups'),
|
||||
new Element('prefix', 'virt-cloud'),
|
||||
new Element('path_style', 'false'),
|
||||
new Element('access_key_id', 'TESTACCESSKEY'),
|
||||
new Element('secret_access_key', 'test-secret-key'),
|
||||
];
|
||||
const form = new Element();
|
||||
form.tagName = 'FORM';
|
||||
form.action = 'https://panel.test/admin/object-storage/config';
|
||||
form.method = 'post';
|
||||
form.dataset.canManage = '1';
|
||||
form.fields = fields;
|
||||
form.elements = Object.fromEntries(fields.map(field => [field.name, field]));
|
||||
form.querySelector = selector => selector === 'input[name="_admin_csrf"]'
|
||||
? form.fields.find(field => field.name === '_admin_csrf') || null
|
||||
: null;
|
||||
form.appendChild = field => form.fields.push(field);
|
||||
|
||||
const nodes = new Map([
|
||||
['objectStorageForm', form],
|
||||
['osNotice', new Element()],
|
||||
['osSave', new Element()],
|
||||
['osTest', new Element()],
|
||||
['osDisable', new Element()],
|
||||
]);
|
||||
const documentListeners = new Map();
|
||||
const requests = [];
|
||||
const context = {
|
||||
URL,
|
||||
Headers,
|
||||
FormData: class {
|
||||
constructor(source) {
|
||||
this.fields = source.fields;
|
||||
}
|
||||
|
||||
forEach(callback) {
|
||||
for (const field of this.fields) callback(field.value, field.name);
|
||||
}
|
||||
},
|
||||
document: {
|
||||
getElementById: id => nodes.get(id) || null,
|
||||
addEventListener: (name, listener) => documentListeners.set(name, listener),
|
||||
createElement: () => new Element(),
|
||||
},
|
||||
location: {
|
||||
href: 'https://panel.test/admin/object-storage',
|
||||
origin: 'https://panel.test',
|
||||
reload() {},
|
||||
},
|
||||
setTimeout() {},
|
||||
fetch(url, options) {
|
||||
requests.push({ url, options });
|
||||
return Promise.resolve({
|
||||
ok: true,
|
||||
status: 200,
|
||||
text: async () => JSON.stringify({ ret: 1, msg: 'saved' }),
|
||||
});
|
||||
},
|
||||
console,
|
||||
};
|
||||
context.window = context;
|
||||
context.ADMIN_CSRF_TOKEN = 'a'.repeat(64);
|
||||
|
||||
vm.runInNewContext(csrfSource, context, { filename: 'admin-csrf.js' });
|
||||
vm.runInNewContext(scriptMatch[1], context, { filename: 'object_storage.tpl' });
|
||||
|
||||
documentListeners.get('submit')({ target: form });
|
||||
form.listeners.get('submit')({ preventDefault() {}, target: form });
|
||||
await Promise.resolve();
|
||||
|
||||
assert.equal(requests.length, 1);
|
||||
assert.equal(requests[0].url, '/admin/object-storage/config');
|
||||
assert.equal(
|
||||
requests[0].options.headers.get('X-Admin-CSRF-Token'),
|
||||
context.ADMIN_CSRF_TOKEN,
|
||||
'Object-storage save lost the administrator CSRF header.',
|
||||
);
|
||||
assert.deepEqual(JSON.parse(requests[0].options.body), {
|
||||
expected_revision: '4',
|
||||
name: 'Vultr Object Storage',
|
||||
endpoint: 'https://ewr1.vultrobjects.com',
|
||||
region: 'us-east-1',
|
||||
bucket: 'virt-backups',
|
||||
prefix: 'virt-cloud',
|
||||
path_style: 'false',
|
||||
access_key_id: 'TESTACCESSKEY',
|
||||
secret_access_key: 'test-secret-key',
|
||||
});
|
||||
|
||||
console.log('Object-storage submit keeps CSRF in the header and sends only business fields.');
|
||||
Loading…
Reference in New Issue