//go:build libvirt package hypervisor import ( "context" "encoding/json" "path/filepath" "testing" "git.luoli.live/root/virt/agent/operation" ) // These call the production mutation entry points, with invalid preconditions // that must return before dereferencing the absent libvirt connection. A // normal refusal must not leave a durable blocker against another operation. func TestMutationPreconditionFailuresDoNotFenceResource(t *testing.T) { backend := &Libvirt{} ctx := context.Background() cases := []struct { name string call func() error }{ {"settings", func() error { _, err := backend.UpdateSettings(ctx, "invalid", SettingsRequest{}); return err }}, {"resize", func() error { _, err := backend.ResizeResources(ctx, "invalid", ResizeResourcesRequest{}); return err }}, {"network", func() error { _, err := backend.ChangeNetwork(ctx, "invalid", ChangeNetworkRequest{}); return err }}, {"network-link", func() error { return backend.SetNetworkState(ctx, "invalid", true, NetworkStateRequest{}) }}, {"service", func() error { _, err := backend.SetServiceState(ctx, "invalid", true, ServiceStateRequest{}) return err }}, {"firewall", func() error { _, err := backend.ApplyFirewall(ctx, "invalid", FirewallPolicy{}); return err }}, {"enter-rescue", func() error { _, err := backend.EnterRescue(ctx, "invalid", RescueRequest{}); return err }}, {"force-rescue", func() error { _, err := backend.ForceStartRescue(ctx, "invalid", ForceRescueStartRequest{}) return err }}, {"exit-rescue", func() error { _, err := backend.ExitRescue(ctx, "invalid", ExitRescueRequest{}); return err }}, {"reinstall", func() error { _, err := backend.Reinstall(ctx, "invalid", ReinstallRequest{}); return err }}, {"delete", func() error { _, err := backend.DeleteVM(ctx, "invalid", DeleteVMRequest{}); return err }}, {"force-delete", func() error { _, err := backend.ForceDeleteVM(ctx, "invalid", ForceDeleteVMRequest{}); return err }}, {"power", func() error { _, err := backend.Power(ctx, "invalid", PowerRequest{Action: PowerStart}); return err }}, {"import-template", func() error { _, err := backend.ImportTemplate(ctx, ImportTemplateRequest{}); return err }}, {"update-template", func() error { _, err := backend.UpdateTemplate(ctx, "invalid", UpdateTemplateRequest{}); return err }}, {"delete-template", func() error { return backend.DeleteTemplate(ctx, "invalid/id") }}, {"import-rescue", func() error { _, err := backend.ImportRescueTemplate(ctx, ImportRescueTemplateRequest{}); return err }}, {"delete-rescue", func() error { return backend.DeleteRescueTemplate(ctx, "invalid") }}, {"import-iso", func() error { _, err := backend.ImportUserISO(ctx, ImportUserISORequest{}); return err }}, {"delete-iso", func() error { return backend.DeleteUserISO(ctx, "invalid", 17) }}, {"download-source", func() error { _, _, _, err := backend.downloadVolume(ctx, nil, "volume", "raw", "invalid", "", 0, 100, "") return err }}, } for _, test := range cases { t.Run(test.name, func(t *testing.T) { journal, err := operation.Open(filepath.Join(t.TempDir(), "journal.db")) if err != nil { t.Fatal(err) } t.Cleanup(func() { _ = journal.Close() }) spec := operation.Spec{OperationID: "precondition-" + test.name, ResourceID: "same-vm-resource", Action: test.name, Fingerprint: operation.Fingerprint("POST", "/v1/vms/test", []byte(`{}`)), Destructive: true} record, replayed, err := journal.Execute(ctx, spec, func(context.Context) (json.RawMessage, error) { return nil, test.call() }) if err == nil || replayed || record.State != operation.StateFailed || record.EffectMayHaveApplied || !record.SafeToResubmit { t.Fatalf("precondition left unknown effects: record=%+v replayed=%v err=%v", record, replayed, err) } spec.OperationID += "-next" called := false _, _, err = journal.Execute(ctx, spec, func(context.Context) (json.RawMessage, error) { called = true return json.RawMessage(`{"ok":true}`), nil }) if err != nil || !called { t.Fatalf("new independent operation blocked: %v", err) } }) } }