"""Model proxy-neighbour flushing during actual generated rollback fragments.""" import os import subprocess import pytest from test_vpc_nft_dataplane import _plan from virsh_panel.shell_contracts import LOCAL_NEIGHBOR_SH from virsh_panel.vpc_dataplane import ( render_apply_script, VPC_APPLY_RUNTIME_SH, VPC_LOCAL_NEIGHBOR_TRANSACTION_SH, ) MOCK = r''' fake_ip() { # This suite isolates proxy ARP; ordinary guest-neighbor state is empty. if [ "$*" = '-o -4 neigh show dev vcv-test' ]; then return 0; fi if [ "$*" = 'link show dev vcv-test' ]; then return 0; fi if [ "$*" = 'link set dev vcv-test down' ]; then if [ "$SCENARIO" != no_flush ]; then : > "$PROXY_STATE"; fi if [ "$SCENARIO" = foreign_after ]; then printf '%s\n' 10.44.0.99 > "$PROXY_STATE"; fi return 0 fi if [ "$*" = 'neigh show proxy dev vcv-test' ]; then [ "$SCENARIO" != read_failure ] || return 97 if [ "$SCENARIO" = long_output ]; then awk '{print $0 " dev vcv-test proxy"}' "$PROXY_STATE" elif [ "$SCENARIO" = short_output ]; then awk '{print $0 " proxy"}' "$PROXY_STATE" elif [ "$SCENARIO" = malformed_output ]; then printf '%s\n' '10.44.0.10 dev wrong-bridge proxy' '10.44.0.11' else cat "$PROXY_STATE" fi return 0 fi if [ "$1 $2 $3" = 'neigh del proxy' ]; then printf '%s\n' "$4" >> "$DELETE_LOG" awk -v address="$4" '$0 != address' "$PROXY_STATE" > "$PROXY_STATE.tmp" mv "$PROXY_STATE.tmp" "$PROXY_STATE" return 0 fi if [ "$1 $2 $3" = 'neigh replace proxy' ]; then printf '%s\n' "$4" >> "$PROXY_STATE" return 0 fi return 99 } vc_vpc_bridge_link_state() { if [ "$SCENARIO" = quarantine_failure ]; then printf up; else printf down; fi } vc_vpc_bridge_topology_matches() { [ "$SCENARIO" != foreign_tap ]; } IP=fake_ip; CMP=cmp; BRIDGE=vcv-test; MODE=ifupdown ROLLBACK_FAILED=no; PROXY_ENTRIES_CHANGED=yes; RUNTIME_QUARANTINED=yes; BRIDGE_TOPOLOGY_CAPTURED=yes; LOCAL_NEIGHBORS_CHANGED=no ''' FOOTER = r''' printf 'rollback_failed=%s\n' "$ROLLBACK_FAILED" if [ "$ROLLBACK_FAILED" = no ]; then printf 'nft_restore_allowed=yes\n'; else printf 'nft_restore_allowed=no\n'; fi ''' @pytest.mark.parametrize("shell", ["/bin/sh", "/bin/bash"]) @pytest.mark.parametrize("scenario", [ "kernel_flush", "no_flush", "long_output", "short_output", "foreign_before", "foreign_after", "foreign_tap", "config_drift", "read_failure", "malformed_output", "quarantine_failure", ]) def test_proxy_rollback_verifies_quarantine_before_restoring(tmp_path, shell, scenario): script = render_apply_script(_plan(), deployment_mode="ifupdown") start = script.index(" # Link-down removes kernel proxy-neighbour entries.") end = script.index(' if [ "$ROUTES_CHANGED" = yes ]; then', start) quarantine = script[start:end] start = script.index(' if [ "$PROXY_ENTRIES_CHANGED" = yes ] ||', script.index(' # vc-policy-rule-rollback-end')) end = script.index(' if [ "$PROXY_FILE_CHANGED" = yes ]; then', start) proxy = script[start:end] restore_start = VPC_APPLY_RUNTIME_SH.index(' while IFS= read -r rollback_proxy; do') restore_end = VPC_APPLY_RUNTIME_SH.index(' vc_vpc_routes_snapshot "$TXN/routes.rollback.restored"', restore_start) proxy += '\nif [ "$ROLLBACK_FAILED" = no ]; then\n' + VPC_APPLY_RUNTIME_SH[restore_start:restore_end] + '\nfi\n' current = tmp_path / 'current' current.write_text('10.44.0.99\n' if scenario == 'foreign_before' else '10.44.0.10\n10.44.0.11\n') (tmp_path / 'proxy.before').write_text('10.44.0.9\n') (tmp_path / 'neighbors.desired').write_text('') deletes = tmp_path / 'deletes' deletes.write_text('') drift = 'ROLLBACK_FAILED=yes\n' if scenario == 'config_drift' else '' env = dict(os.environ, SCENARIO=scenario, TXN=str(tmp_path), PROXY_STATE=str(current), DELETE_LOG=str(deletes)) helpers = LOCAL_NEIGHBOR_SH + '\n' + VPC_LOCAL_NEIGHBOR_TRANSACTION_SH baseline = '\nvc_vpc_neighbors_baseline\n' result = subprocess.run([shell, '-s'], input='set -eu\n' + MOCK + helpers + baseline + quarantine + drift + proxy + FOOTER, text=True, capture_output=True, env=env, check=False) assert result.returncode == 0, result.stderr values = dict(line.split('=', 1) for line in result.stdout.splitlines()) success = scenario in ('kernel_flush', 'no_flush', 'long_output', 'short_output') assert values['rollback_failed'] == ('no' if success else 'yes') assert values['nft_restore_allowed'] == ('yes' if success else 'no') if success: assert current.read_text() == '10.44.0.9\n' if scenario != 'no_flush': assert deletes.read_text() == '' if scenario in ('foreign_tap', 'config_drift'): assert current.read_text() == '' assert deletes.read_text() == '' if scenario == 'foreign_after': assert current.read_text() == '10.44.0.99\n' assert deletes.read_text() == ''