package auth import ( "bytes" "errors" "net/http" "testing" "time" ) var authTestSecret = []byte("0123456789abcdef0123456789abcdef") func signedRequest(t *testing.T, method, target string, body []byte, now time.Time, nonce string) *http.Request { t.Helper() r, err := http.NewRequest(method, target, bytes.NewReader(body)) if err != nil { t.Fatal(err) } actor := Actor{UserID: 42, CanManage: true, OperationID: "operation-1234"} if err := Sign(r, body, actor, authTestSecret, now.Unix(), nonce); err != nil { t.Fatal(err) } return r } func TestAuthenticateAndRejectReplay(t *testing.T) { now := time.Unix(2_000_000_000, 0) a, err := New(authTestSecret, 5*time.Minute, 10*time.Minute) if err != nil { t.Fatal(err) } a.SetClockForTesting(func() time.Time { return now }) r := signedRequest(t, http.MethodPost, "https://agent.test/v1/vms/vm-1/actions?wait=false", []byte(`{"action":"start"}`), now, "abcdefghijklmnop") actor, err := a.Authenticate(r, []byte(`{"action":"start"}`)) if err != nil { t.Fatalf("valid signature rejected: %v", err) } if actor.UserID != 42 || actor.OperationID != "operation-1234" { t.Fatalf("unexpected actor: %#v", actor) } if _, err := a.Authenticate(r, []byte(`{"action":"start"}`)); !errors.Is(err, ErrReplay) { t.Fatalf("replay error = %v, want ErrReplay", err) } } func TestNonceTTLCoversEntireSignedRequestWindow(t *testing.T) { if _, err := New(authTestSecret, 5*time.Minute, 10*time.Minute-time.Nanosecond); err == nil { t.Fatal("nonce TTL shorter than twice the clock skew was accepted") } now := time.Unix(2_000_000_000, 0) a, err := New(authTestSecret, 5*time.Minute, 10*time.Minute) if err != nil { t.Fatal(err) } r := signedRequest(t, http.MethodGet, "https://agent.test/v1/health", nil, now.Add(5*time.Minute), "futureNonce12345") a.SetClockForTesting(func() time.Time { return now }) if _, err := a.Authenticate(r, nil); err != nil { t.Fatalf("future-boundary request rejected: %v", err) } a.SetClockForTesting(func() time.Time { return now.Add(10 * time.Minute) }) if _, err := a.Authenticate(r, nil); !errors.Is(err, ErrReplay) { t.Fatalf("nonce was released while signature remained valid: %v", err) } } func TestAuthenticateBindsBodyPathAndQuery(t *testing.T) { now := time.Unix(2_000_000_000, 0) a, _ := New(authTestSecret, 5*time.Minute, 10*time.Minute) a.SetClockForTesting(func() time.Time { return now }) r := signedRequest(t, http.MethodPut, "https://agent.test/v1/vms/a%2Fb/firewall?revision=7", []byte(`{"default":"drop"}`), now, "qrstuvwxyzABCDEF") if _, err := a.Authenticate(r, []byte(`{"default":"accept"}`)); !errors.Is(err, ErrUnauthorized) { t.Fatalf("changed body error = %v", err) } r.URL.RawQuery = "revision=8" if _, err := a.Authenticate(r, []byte(`{"default":"drop"}`)); !errors.Is(err, ErrUnauthorized) { t.Fatalf("changed target error = %v", err) } } func TestAuthenticateRejectsExpiredAndNonCanonicalHeaders(t *testing.T) { now := time.Unix(2_000_000_000, 0) a, _ := New(authTestSecret, time.Minute, 2*time.Minute) a.SetClockForTesting(func() time.Time { return now }) r := signedRequest(t, http.MethodGet, "https://agent.test/v1/health", nil, now.Add(-2*time.Minute), "1234567890abcdef") if _, err := a.Authenticate(r, nil); !errors.Is(err, ErrUnauthorized) { t.Fatalf("expired request error = %v", err) } r = signedRequest(t, http.MethodGet, "https://agent.test/v1/health", nil, now, "fedcba0987654321") r.Header.Set(HeaderBodyDigest, "ABCDEF"+r.Header.Get(HeaderBodyDigest)[6:]) if _, err := a.Authenticate(r, nil); !errors.Is(err, ErrUnauthorized) { t.Fatalf("uppercase digest error = %v", err) } } func TestPHPHMACFixtureParity(t *testing.T) { secret := []byte("test-secret-which-is-at-least-32-bytes") body := []byte(`{"name":"测试"}`) request, err := http.NewRequest(http.MethodPost, "https://agent.test/v1/vms?wait=1", bytes.NewReader(body)) if err != nil { t.Fatal(err) } actor := Actor{ UserID: 17, IsAdmin: true, IsSuperAdmin: true, CanManage: true, OperationID: "operation_12345678", } if err := Sign(request, body, actor, secret, 1_800_000_000, "00112233445566778899aabbccddeeff"); err != nil { t.Fatal(err) } if got, want := request.Header.Get(HeaderActor), "eyJ1c2VyX2lkIjoxNywiaXNfYWRtaW4iOnRydWUsImlzX3N1cGVyX2FkbWluIjp0cnVlLCJjYW5fbWFuYWdlIjp0cnVlLCJvcGVyYXRpb25faWQiOiJvcGVyYXRpb25fMTIzNDU2NzgifQ"; got != want { t.Fatalf("actor header = %q, want %q", got, want) } if got, want := request.Header.Get(HeaderBodyDigest), "827361636cbd9dfdb06cb0fc540ee89605f405bfd3e5dd36e2eec7d10908c600"; got != want { t.Fatalf("body digest = %q, want %q", got, want) } if got, want := request.Header.Get(HeaderSignature), "9a3fd49fcedbe4d79f6bf8efc5c0867efb5b6d0bffdc9bca602d24507205dcd7"; got != want { t.Fatalf("signature = %q, want %q", got, want) } } func TestSystemRecoveryActorIsStrictlyUnprivilegedAndOperationBound(t *testing.T) { valid := Actor{ UserID: 0, SystemRecovery: true, OperationID: "operation-recovery-1234", } if err := valid.Validate(); err != nil { t.Fatalf("valid system recovery actor rejected: %v", err) } for name, mutate := range map[string]func(*Actor){ "positive user": func(actor *Actor) { actor.UserID = 1 }, "administrator": func(actor *Actor) { actor.IsAdmin = true }, "super admin": func(actor *Actor) { actor.IsSuperAdmin = true }, "manage capability": func(actor *Actor) { actor.CanManage = true }, "missing operation": func(actor *Actor) { actor.OperationID = "" }, } { t.Run(name, func(t *testing.T) { actor := valid mutate(&actor) if err := actor.Validate(); err == nil { t.Fatalf("invalid system recovery actor accepted: %#v", actor) } }) } }