You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
virt/web/tests/CloudInstancePageSsrContrac...

172 lines
11 KiB
PHP

<?php
// Static regression contract for the instance list/detail hybrid SSR boundary.
// PHP and database snapshots own first paint; libvirt is consulted only by
// the small status endpoints after the page is already usable.
$root = dirname(__DIR__);
$assert = static function ($condition, string $message): void {
if (!$condition) {
throw new RuntimeException($message);
}
};
$section = static function (string $source, string $start, string $end): string {
$offset = strpos($source, $start);
if ($offset === false) {
return '';
}
$limit = strpos($source, $end, $offset + strlen($start));
return $limit === false ? substr($source, $offset)
: substr($source, $offset, $limit - $offset);
};
$page = file_get_contents($root . '/app/Controllers/CloudPageController.php');
$api = file_get_contents($root . '/app/Controllers/CloudApiController.php');
$service = file_get_contents($root . '/app/Services/Cloud/CloudInstancePageService.php');
$middleware = file_get_contents($root . '/app/Middleware/CloudApi.php');
$routes = file_get_contents($root . '/config/routes_cloud.php');
$worker = file_get_contents($root . '/app/Services/Cloud/CloudWorkerService.php');
$pageService = $section($service, 'public static function forActor(',
'public static function detailForActor(');
$assert(str_contains($service, "CloudInstance::where('status', '<>', 'deleted')")
&& str_contains($service, "if (!(\$actor['is_admin'] ?? false))")
&& str_contains($service, "->where('user_id', (int) \$actor['user_id'])")
&& str_contains($service, '->limit($perPage)')
&& str_contains($service, '->get(self::listColumns())')
&& str_contains($service, "'per_page' => \$perPage")
&& str_contains($service, "'page_count' => \$count")
&& !str_contains($service, 'CloudEngineClient'),
'Instance first-paint service must remain actor scoped, bounded and engine free.');
$assert(str_contains($pageService, 'self::listSnapshots($records)')
&& !str_contains($pageService, 'self::snapshots($records, $actor)'),
'Instance list first paint must not load detail-only billing and credential data.');
$assert(str_contains($service, "\$canDelete = \$lifecycleActive && (\$owner || \$global)")
&& str_contains($service, "'can_view_credential' => \$owner || \$global")
&& str_contains($service, "'can_renew' => \$lifecycleActive && \$owner")
&& str_contains($service, "CloudInstanceMetadata::state(\$runtime['state'] ?? 'unknown')"),
'Read-only administrators must not inherit owner or super-admin instance operations.');
$assert(!str_contains($service, 'CloudHost::')
&& str_contains($service, 'CloudServicePeriod::whereIn')
&& str_contains($service, "->groupBy('instance_id')"),
'Instance pages must use safe region snapshots and bulk-load billing dependencies.');
$assert(str_contains($service, 'private static function listItem(')
&& str_contains($service, 'private static function listSnapshots(')
&& str_contains($service, "->get(['id', 'uuid', 'host_id', 'name'])")
&& str_contains($service, 'public static function powerStatus(')
&& str_contains($service, "'live_state_available'")
&& str_contains($service, "array_intersect_key"),
'Instance list bootstrap and polling payloads must remain detail-free and bounded.');
$assert(str_contains($service, 'public static function statusForActor(')
&& str_contains($service, 'CloudInstanceRuntimeService::forInstances([$instance])')
&& str_contains($service, "'state_sync_status' =>")
&& str_contains($service, "'traffic_upload_bytes',")
&& !str_contains($section($service, 'public static function statusForActor(',
'public static function forActorIds('), "'host_id' =>")
&& !str_contains($section($service, 'public static function statusForActor(',
'public static function forActorIds('), 'credential_cipher'),
'Detail status polling must load only mutable public state.');
$instances = $section($page, 'public function instances(', 'public function detail(');
$detail = $section($page, 'public function detail(', 'public function deploy(');
$assert(str_contains($instances, 'CloudAccess::actor(false)')
&& str_contains($instances, 'CloudInstancePageService::forActor')
&& str_contains($instances, "'cloud_vm_rows'")
&& str_contains($instances, "'cloud_vm_bootstrap_json'"),
'Instance list HTML must embed its owner-scoped database first page without a cloud session.');
$assert(str_contains($detail, 'CloudAccess::actor(false)')
&& str_contains($detail, 'CloudInstancePageService::detailForActor')
&& str_contains($detail, "'cloud_vm_view'")
&& str_contains($detail, "'cloud_vm_bootstrap_json'"),
'Instance detail HTML must embed a useful owner-scoped database snapshot.');
$assert(str_contains($page, "'can_rename' => (bool) (\$vm['can_rename'] ?? false)"),
'Instance detail view dropped the explicit display-name mutation permission.');
$assert(str_contains($page, 'JSON_HEX_TAG')
&& str_contains($page, "'csrf_token' => AdminCsrf::token()")
&& str_contains($page, "withHeader('Cache-Control', 'private, no-store')"),
'Embedded instance state must be script-safe, authenticated and non-cacheable.');
$pageRoute = strpos($routes, "'/vms/page'");
$metadataRoute = strpos($routes, "'/vms/metadata'");
$statusesRoute = strpos($routes, "'/vms/statuses'");
$metadataOneRoute = strpos($routes, "'/vms/{id:[0-9]+}/metadata'");
$statusRoute = strpos($routes, "'/vms/{id:[0-9]+}/status'");
$displayNameRoute = strpos($routes, "'/vms/{id:[0-9]+}/display-name'");
$legacyRoute = strpos($routes, "'/vms/{id}'");
$assert($pageRoute !== false && $metadataRoute !== false && $statusesRoute !== false
&& $metadataOneRoute !== false && $statusRoute !== false && $displayNameRoute !== false
&& $legacyRoute !== false && $pageRoute < $legacyRoute
&& $metadataRoute < $legacyRoute && $statusesRoute < $legacyRoute
&& $metadataOneRoute < $legacyRoute && $statusRoute < $legacyRoute
&& $displayNameRoute < $legacyRoute,
'Lightweight fixed VM routes must precede the legacy dynamic VM route.');
$pageApi = $section($api, 'public function vmPage(', 'public function vmMetadata(');
$metadataApi = $section($api, 'public function vmMetadata(', 'public function vmStatuses(');
$statusesApi = $section($api, 'public function vmStatuses(', 'public function vmStatus(');
$statusApi = $section($api, 'public function vmStatus(', 'public function vm(');
$displayNameApi = $section($api, 'public function displayName(', 'public function operationLogs(');
$assert(str_contains($pageApi, '$this->billingActor($request)')
&& str_contains($pageApi, 'CloudInstancePageService::forActor')
&& !str_contains($pageApi, 'CloudEngineClient'),
'Paginated VM rows must not create an engine session or contact libvirt.');
$assert(str_contains($metadataApi, 'CloudInstancePageService::forActorIds')
&& str_contains($metadataApi, 'CloudInstancePageService::forActorIds($actor, $ids, true)')
&& str_contains($metadataApi, 'CloudInstanceMetadata::publicView')
&& str_contains($metadataApi, 'domain_metadata operation yet')
&& !str_contains($metadataApi, 'CloudEngineClient')
&& !str_contains($metadataApi, 'vm-metadata?ids='),
'Static VM metadata must use the actor-scoped PHP snapshot until a typed Agent read exists.');
$assert(str_contains($statusesApi, 'CloudInstancePageService::forActorIds')
&& str_contains($statusesApi, '$this->vmProbeTargets($actor, $ids)')
&& str_contains($statusesApi, '$this->agentObservationService()->observeMany(')
&& str_contains($statusesApi, '$observationTargets')
&& str_contains($statusesApi, 'CloudInstancePageService::powerStatus')
&& str_contains($statusesApi, ". ':' . \$uuid")
&& !str_contains($statusesApi, 'CloudEngineClient')
&& !str_contains($statusesApi, 'vm-states?ids='),
'Batch VM status must intersect owner UUIDs, preserve host identity and use typed Agent observations.');
$assert(str_contains($statusApi, 'CloudInstancePageService::statusForActor')
&& str_contains($statusApi, "['live'] ?? '') === '1'")
&& str_contains($statusApi, '$this->agentObservationService()->observe(')
&& !str_contains($statusApi, 'CloudEngineClient')
&& str_contains($statusApi, 'hash_equals(')
&& str_contains($statusApi, 'CloudInstanceRuntimeService::beginCurrentObservation(')
&& str_contains($statusApi, 'CloudInstanceRuntimeService::normalizeState(')
&& str_contains($statusApi, 'CloudInstanceRuntimeService::markObserved(')
&& str_contains($statusApi, '$runtimeRevision')
&& str_contains($statusApi, "\$observedState !== 'unknown'")
&& strpos($statusApi, 'CloudInstanceRuntimeService::beginCurrentObservation(')
< strpos($statusApi, '$this->agentObservationService()->observe(')
&& strrpos($statusApi, 'hash_equals(')
< strpos($statusApi, 'CloudInstanceRuntimeService::markObserved('),
'Single VM status must keep its cache fallback and bounded, UUID-checked, write-through live path.');
$vmData = $section($api, 'private function vmData(', 'public function vms(');
$assert(str_contains($vmData, "'name' => (string) \$instance->name")
&& str_contains($vmData, '$this->publicVmMetadata($instance')
&& str_contains($api, 'private function publicVmMetadata(')
&& str_contains($api, 'private function publicVmSpec(')
&& str_contains($api, 'private function publicMetrics(')
&& str_contains($api, 'private function publicDailyTraffic(')
&& str_contains($api, '$this->publicMetrics($value')
&& str_contains($api, '$this->publicDailyTraffic($value')
&& !str_contains($vmData, "'host_id' =>")
&& !str_contains($vmData, 'host?->region')
&& !str_contains($vmData, 'CloudInput::safeResult($vm)'),
'Full VM responses must use the strict public metadata DTO and keep the database display name authoritative.');
$assert(str_contains($displayNameApi, 'CloudInput::only($body, [\'name\'])')
&& str_contains($displayNameApi, 'CloudInstanceNameService::rename(')
&& !str_contains($displayNameApi, 'CloudEngineClient')
&& !str_contains($displayNameApi, 'CloudJob'),
'Display-name mutation must remain a strict PHP/database-only endpoint.');
$assert(str_contains($middleware, "\$path === '/api/v1/vms/page'")
&& str_contains($middleware, "^/api/v1/vms/[0-9]+/status\$#D")
&& str_contains($middleware, "^/api/v1/vms/[0-9]+/display-name\$#D")
&& str_contains($middleware, 'CloudAccess::actor(!$databaseOnly)'),
'Database-only VM pagination and detail status must not allocate a private-engine cloud session.');
$assert(str_contains($worker, '$newInstance = $instance === null;')
&& str_contains($worker, 'if ($newInstance)')
&& str_contains($worker, "\$instance->name = \$payload['body']['name'];"),
'A late create reconciliation must not overwrite an owner-renamed display name.');
echo "Instance list/detail SSR and lightweight live-status contract passed.\n";