You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
91 lines
3.5 KiB
Python
91 lines
3.5 KiB
Python
"""Preserve new-bridge ownership until rollback proves bridge deletion."""
|
|
import shlex
|
|
import subprocess
|
|
|
|
import pytest
|
|
from test_vpc_nft_dataplane import _plan
|
|
from virsh_panel.vpc_dataplane import render_apply_script
|
|
from virsh_panel.shell_contracts import BRIDGE_PORT_RECORDS_SH
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('mode', ['ifupdown', 'networkmanager_nmcli'])
|
|
@pytest.mark.parametrize('failure', ['ports', 'inspect', 'delete', 'none'])
|
|
@pytest.mark.parametrize('owner_before', [False, True])
|
|
def test_new_bridge_rollback_keeps_owner_and_journal_until_deleted(
|
|
tmp_path, mode, failure, owner_before,
|
|
):
|
|
script = render_apply_script(_plan(), deployment_mode=mode)
|
|
rollback = script[script.index('rollback() {'):script.index(
|
|
'trap rollback EXIT HUP INT TERM')]
|
|
# Execute the actual generated bridge cleanup and transaction finalizer.
|
|
# Only the kernel commands are stubbed; ownership/journal files are real.
|
|
bridge_cleanup = rollback[rollback.index(
|
|
' if [ -n "$SYSCTL_TMP" ]; then'):rollback.index(
|
|
' if [ "$MODE" = ifupdown ]')]
|
|
finalizer_marker = ' if [ "$ROLLBACK_NEW_BRIDGE_RETAINED" = no ]; then'
|
|
finalizer = rollback[rollback.index(finalizer_marker):rollback.rindex('}')]
|
|
txn = tmp_path / 'txn'
|
|
txn.mkdir()
|
|
(txn / 'state').write_text('preparing\n')
|
|
(txn / 'inflight').write_text('original-operation\n')
|
|
owner = tmp_path / 'owner'
|
|
owner.write_text('current-owner\n')
|
|
if owner_before:
|
|
(txn / 'owner.before').write_text('before-owner\n')
|
|
log = tmp_path / 'commands'
|
|
harness = '\n'.join((
|
|
'set -u; set +e',
|
|
BRIDGE_PORT_RECORDS_SH,
|
|
'status=71; BRIDGE_CREATED=yes; BRIDGE_WAS_UP=no; BRIDGE_TOPOLOGY_CAPTURED=no',
|
|
'BRIDGE=vcv-test; ROLLBACK_FAILED=no; SYSCTL_TMP=',
|
|
'MODE=' + shlex.quote(mode),
|
|
'TXN=' + shlex.quote(str(txn)),
|
|
'OWNER_FILE=' + shlex.quote(str(owner)),
|
|
'STATE_FILE=' + shlex.quote(str(tmp_path / 'saved-state')),
|
|
'VC_TEST_FAILURE=' + shlex.quote(failure),
|
|
'VC_TEST_LOG=' + shlex.quote(str(log)),
|
|
r'''
|
|
vc_test_bridge() {
|
|
printf '%s\n' "bridge $*" >> "$VC_TEST_LOG"
|
|
case "$VC_TEST_FAILURE" in
|
|
inspect) return 3 ;;
|
|
ports) printf '%s\n' '22: vnet3: <BROADCAST,UP> master vcv-test state forwarding' ;;
|
|
esac
|
|
return 0
|
|
}
|
|
vc_test_ip() {
|
|
printf '%s\n' "ip $*" >> "$VC_TEST_LOG"
|
|
if [ "$*" = '-o link show master vcv-test' ]; then
|
|
vc_test_bridge; return $?
|
|
fi
|
|
[ "$*" = 'link del dev vcv-test type bridge' ] || return 91
|
|
[ "$VC_TEST_FAILURE" != delete ] || return 4
|
|
}
|
|
IP=vc_test_ip
|
|
BRIDGE_CMD=vc_test_bridge
|
|
'''.strip(),
|
|
bridge_cleanup,
|
|
finalizer,
|
|
))
|
|
result = subprocess.run(['/bin/sh', '-c', harness], text=True,
|
|
capture_output=True, check=False)
|
|
commands = log.read_text()
|
|
if failure == 'none':
|
|
assert result.returncode == 71, result.stderr
|
|
assert not txn.exists()
|
|
if owner_before:
|
|
assert owner.read_text() == 'before-owner\n'
|
|
else:
|
|
assert not owner.exists()
|
|
assert 'ip link del dev vcv-test type bridge' in commands
|
|
else:
|
|
assert result.returncode == 79, result.stderr
|
|
assert owner.read_text() == 'current-owner\n'
|
|
assert (txn / 'state').read_text() == 'rollback_failed\n'
|
|
assert (txn / 'inflight').read_text() == 'original-operation\n'
|
|
if failure in ('ports', 'inspect'):
|
|
assert 'ip link del' not in commands
|
|
else:
|
|
assert 'ip link del dev vcv-test type bridge' in commands
|