You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
110 lines
4.7 KiB
Python
110 lines
4.7 KiB
Python
from virsh_panel.private_network import observe_private_state_from_xml
|
|
|
|
|
|
def _xml(*, private=True, link="up", private_source="vc-private",
|
|
private_ip="10.24.3.7/32", verified="true", private_filter=False,
|
|
public_source="br0", private_type="bridge",
|
|
public_alias="ua-public0", private_alias="ua-private0"):
|
|
private_block = ""
|
|
if private:
|
|
filt = '<filterref filter="clean-traffic" />' if private_filter else ""
|
|
source = (f'<source bridge="{private_source}" />'
|
|
if private_type == "bridge"
|
|
else f'<source network="{private_source}" />')
|
|
private_block = f'''<interface type="{private_type}">
|
|
<mac address="52:54:00:aa:bb:cc" />
|
|
{source}
|
|
<link state="{link}" />{filt}
|
|
<alias name="{private_alias}" />
|
|
</interface>'''
|
|
return f'''<domain><uuid>00000000-0000-4000-8000-000000000001</uuid>
|
|
<metadata><panel:managed xmlns:panel="urn:virsh-panel:1" private-ip-cidr="{private_ip or ''}"
|
|
private-network-verified="{verified}" /></metadata>
|
|
<devices>
|
|
<interface type="bridge"><mac address="52:54:00:11:22:33" />
|
|
<source bridge="{public_source}" /><alias name="{public_alias}" /></interface>
|
|
{private_block}
|
|
</devices></domain>'''
|
|
|
|
|
|
def test_private_state_without_private_nic_is_confirmed_disabled():
|
|
state = observe_private_state_from_xml(_xml(private=False), vm_uuid="00000000-0000-4000-8000-000000000001", observed_at=10)
|
|
assert state["state"] == "disabled"
|
|
assert state["readback"] == "confirmed"
|
|
assert state["interface"] is None
|
|
|
|
|
|
def test_private_state_requires_verified_independent_bridge_and_ip():
|
|
state = observe_private_state_from_xml(_xml(), observed_at=10)
|
|
assert state["state"] == "degraded"
|
|
assert state["reason_code"] == "private_source_unverified"
|
|
state = observe_private_state_from_xml(_xml(), host_verified=True, observed_at=10)
|
|
assert state["state"] == "active"
|
|
assert state["readback"] == "confirmed"
|
|
assert state["private_ip_cidr"] == "10.24.3.7/32"
|
|
|
|
identified = observe_private_state_from_xml(
|
|
_xml().replace('private-network-verified="true"',
|
|
'private-network-verified="true" private-vpc-id="vpc-a" '
|
|
'private-member-id="member-a"'),
|
|
host_verified=True,
|
|
)
|
|
assert identified["vpc_id"] == "vpc-a"
|
|
assert identified["member_id"] == "member-a"
|
|
|
|
unverified = observe_private_state_from_xml(_xml(verified="false"))
|
|
assert unverified["state"] == "degraded"
|
|
assert unverified["reason_code"] == "private_source_unverified"
|
|
|
|
missing_ip = observe_private_state_from_xml(_xml(private_ip=None))
|
|
assert missing_ip["state"] == "degraded"
|
|
assert missing_ip["reason_code"] == "private_ip_missing"
|
|
|
|
|
|
def test_private_state_marks_link_down_suspended():
|
|
state = observe_private_state_from_xml(_xml(link="down"), host_verified=True)
|
|
assert state["state"] == "suspended"
|
|
assert state["link_state"] == "down"
|
|
|
|
|
|
def test_private_state_rejects_public_source_or_filter():
|
|
shared = observe_private_state_from_xml(_xml(private_source="br0"))
|
|
assert shared["state"] == "degraded"
|
|
assert shared["reason_code"] == "private_source_invalid"
|
|
|
|
filtered = observe_private_state_from_xml(_xml(private_filter=True), host_verified=True)
|
|
assert filtered["state"] == "degraded"
|
|
assert filtered["reason_code"] == "private_filter_present"
|
|
|
|
|
|
def test_private_network_source_network_is_not_proven_isolated():
|
|
state = observe_private_state_from_xml(
|
|
_xml(private_source="default", private_type="network"), host_verified=True
|
|
)
|
|
# The helper only accepts an explicit host bridge; a libvirt network name
|
|
# does not prove which bridge it resolves to.
|
|
assert state["state"] == "degraded"
|
|
assert state["reason_code"] == "private_source_invalid"
|
|
|
|
|
|
def test_private_state_rejects_ambiguous_extra_nic_without_private_role():
|
|
xml = _xml(private=False).replace(
|
|
'</devices>',
|
|
'<interface type="bridge"><mac address="52:54:00:dd:ee:ff" />'
|
|
'<source bridge="vpc0" /></interface></devices>',
|
|
)
|
|
state = observe_private_state_from_xml(xml)
|
|
assert state["state"] == "degraded"
|
|
assert state["reason_code"] == "private_interface_role_invalid"
|
|
|
|
|
|
def test_private_state_accepts_generated_public_during_live_alias_migration():
|
|
for public_alias in ("net0", "ua-net-0"):
|
|
state = observe_private_state_from_xml(
|
|
_xml(public_alias=public_alias), host_verified=True, observed_at=10,
|
|
)
|
|
assert state["state"] == "active"
|
|
assert state["readback"] == "confirmed"
|
|
# The API exposes the stable product/cloud-init role, not libvirt XML.
|
|
assert state["interface"] == "private0"
|