Accept anything in prop value as long as it can `to_string`

pull/427/head
Uku Taht 6 years ago
parent 0a530a0f66
commit 19a9e314fc

@ -97,7 +97,7 @@ defmodule PlausibleWeb.Api.ExternalController do
browser_version: (ua && browser_version(ua)) || "",
screen_size: calculate_screen_size(params["screen_width"]) || "",
"meta.key": Map.keys(params["meta"]),
"meta.value": Map.values(params["meta"])
"meta.value": Map.values(params["meta"]) |> Enum.map(&Kernel.to_string/1)
}
changeset = Plausible.ClickhouseEvent.changeset(%Plausible.ClickhouseEvent{}, event_attrs)

@ -391,6 +391,27 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
assert event.name == "custom event"
end
test "casts custom props to string", %{conn: conn} do
params = %{
name: "Signup",
url: "http://gigride.live/",
domain: "custom-prop-test.com",
props: Jason.encode!(%{
bool_test: true,
number_test: 12
})
}
conn
|> put_req_header("content-type", "text/plain")
|> post("/api/event", Jason.encode!(params))
event = get_event("custom-prop-test.com")
assert Map.get(event, :"meta.key") == ["bool_test", "number_test"]
assert Map.get(event, :"meta.value") == ["true", "12"]
end
test "ignores a malformed referrer URL", %{conn: conn} do
params = %{
name: "pageview",

Loading…
Cancel
Save