|
|
|
|
@ -1,5 +1,6 @@
|
|
|
|
|
defmodule PlausibleWeb.FunnelSettingsTest do
|
|
|
|
|
use PlausibleWeb.ConnCase, async: false
|
|
|
|
|
use PlausibleWeb.ConnCase, async: true
|
|
|
|
|
import Phoenix.LiveViewTest
|
|
|
|
|
|
|
|
|
|
describe "GET /:website/settings/funnels" do
|
|
|
|
|
setup [:create_user, :log_in, :create_site]
|
|
|
|
|
@ -12,22 +13,187 @@ defmodule PlausibleWeb.FunnelSettingsTest do
|
|
|
|
|
assert resp =~ "Compose goals into funnels"
|
|
|
|
|
assert resp =~ "From blog to signup"
|
|
|
|
|
assert resp =~ "From signup to blog"
|
|
|
|
|
doc = Floki.parse_document!(resp)
|
|
|
|
|
|
|
|
|
|
assert [{"a", _, _}] = Floki.find(doc, "a[href=\"https://plausible.io/docs/funnels\"]")
|
|
|
|
|
assert element_exists?(resp, "a[href=\"https://plausible.io/docs/funnels\"]")
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
test "if goals are present, Add Funnel button is rendered", %{conn: conn, site: site} do
|
|
|
|
|
:ok = setup_funnels(site)
|
|
|
|
|
conn = get(conn, "/#{site.domain}/settings/funnels")
|
|
|
|
|
doc = conn |> html_response(200) |> Floki.parse_document!()
|
|
|
|
|
assert [_] = Floki.find(doc, ~S/button[phx-click="add-funnel"]/)
|
|
|
|
|
resp = conn |> html_response(200)
|
|
|
|
|
assert element_exists?(resp, ~S/button[phx-click="add-funnel"]/)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
test "if not enough goals are present, a hint to create goals is rendered", %{
|
|
|
|
|
conn: conn,
|
|
|
|
|
site: site
|
|
|
|
|
} do
|
|
|
|
|
{:ok, _} = Plausible.Goals.create(site, %{"page_path" => "/go/to/blog/**"})
|
|
|
|
|
conn = get(conn, "/#{site.domain}/settings/funnels")
|
|
|
|
|
|
|
|
|
|
doc = conn |> html_response(200)
|
|
|
|
|
assert Floki.text(doc) =~ "You need to define at least two goals to create a funnel."
|
|
|
|
|
|
|
|
|
|
add_goals_path = Routes.site_path(conn, :new_goal, site.domain)
|
|
|
|
|
assert element_exists?(doc, ~s/a[href="#{add_goals_path}"]/)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe "FunnelSettings component" do
|
|
|
|
|
setup [:create_user, :log_in, :create_site]
|
|
|
|
|
|
|
|
|
|
test "renders the funnel form on clicking 'Add Funnel' button", %{conn: conn, site: site} do
|
|
|
|
|
setup_goals(site)
|
|
|
|
|
lv = get_liveview(conn, site)
|
|
|
|
|
doc = render_click(lv, "add-funnel")
|
|
|
|
|
assert element_exists?(doc, ~s/form[phx-change="validate"][phx-submit="save"]/)
|
|
|
|
|
assert element_exists?(doc, ~s/form input[type="text"][name="funnel[name]"]/)
|
|
|
|
|
|
|
|
|
|
refute element_exists?(
|
|
|
|
|
doc,
|
|
|
|
|
~s/input[type="hidden"][name="funnel[steps][][goal_id]"]#submit-step-1/
|
|
|
|
|
)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
test "renders steps input once funnel name is provided", %{conn: conn, site: site} do
|
|
|
|
|
setup_goals(site)
|
|
|
|
|
lv = get_liveview(conn, site)
|
|
|
|
|
|
|
|
|
|
doc = lv |> element(~s/button[phx-click="add-funnel"]/) |> render_click()
|
|
|
|
|
|
|
|
|
|
step_setup_controls = [
|
|
|
|
|
~s/input[type="hidden"][name="funnel[steps][][goal_id]"]#submit-step-1/,
|
|
|
|
|
~s/input[type="hidden"][name="funnel[steps][][goal_id]"]#submit-step-2/,
|
|
|
|
|
~s/input[type="text"][name="display-step-1"]#step-1/,
|
|
|
|
|
~s/input[type="text"][name="display-step-2"]#step-2/,
|
|
|
|
|
~s/a[phx-click="add-step"]/
|
|
|
|
|
]
|
|
|
|
|
|
|
|
|
|
refute Enum.any?(step_setup_controls, &element_exists?(doc, &1))
|
|
|
|
|
|
|
|
|
|
doc =
|
|
|
|
|
lv
|
|
|
|
|
|> element("form")
|
|
|
|
|
|> render_change(%{funnel: %{name: "My test funnel"}})
|
|
|
|
|
|
|
|
|
|
Enum.each(step_setup_controls, &assert(element_exists?(doc, &1)))
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
test "clicking 'Add another step' adds a pair of inputs and renders remove step buttons", %{
|
|
|
|
|
conn: conn,
|
|
|
|
|
site: site
|
|
|
|
|
} do
|
|
|
|
|
setup_goals(site)
|
|
|
|
|
lv = get_liveview(conn, site)
|
|
|
|
|
|
|
|
|
|
lv |> element(~s/button[phx-click="add-funnel"]/) |> render_click()
|
|
|
|
|
lv |> element("form") |> render_change(%{funnel: %{name: "My test funnel"}})
|
|
|
|
|
doc = lv |> element(~s/a[phx-click="add-step"]/) |> render_click()
|
|
|
|
|
|
|
|
|
|
assert element_exists?(
|
|
|
|
|
doc,
|
|
|
|
|
~s/input[type="hidden"][name="funnel[steps][][goal_id]"]#submit-step-3/
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert element_exists?(doc, ~s/input[type="text"][name="display-step-1"]#step-1/)
|
|
|
|
|
|
|
|
|
|
assert element_exists?(
|
|
|
|
|
doc,
|
|
|
|
|
~s/svg#remove-step-1[phx-click="remove-step"][phx-value-step-idx="1"]/
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert element_exists?(
|
|
|
|
|
doc,
|
|
|
|
|
~s/svg#remove-step-2[phx-click="remove-step"][phx-value-step-idx="2"]/
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
assert element_exists?(
|
|
|
|
|
doc,
|
|
|
|
|
~s/svg#remove-step-3[phx-click="remove-step"][phx-value-step-idx="3"]/
|
|
|
|
|
)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
test "clicking the 'remove step' button removes a step", %{site: site, conn: conn} do
|
|
|
|
|
setup_goals(site)
|
|
|
|
|
lv = get_liveview(conn, site)
|
|
|
|
|
|
|
|
|
|
lv |> element(~s/button[phx-click="add-funnel"]/) |> render_click()
|
|
|
|
|
lv |> element("form") |> render_change(%{funnel: %{name: "My test funnel"}})
|
|
|
|
|
lv |> element(~s/a[phx-click="add-step"]/) |> render_click()
|
|
|
|
|
|
|
|
|
|
doc = lv |> element(~s/#remove-step-2/) |> render_click()
|
|
|
|
|
|
|
|
|
|
assert element_exists?(doc, ~s/input#step-1/)
|
|
|
|
|
assert element_exists?(doc, ~s/input#step-3/)
|
|
|
|
|
refute element_exists?(doc, ~s/input#step-2/)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
test "save button becomes active once at least two steps are selected", %{
|
|
|
|
|
conn: conn,
|
|
|
|
|
site: site
|
|
|
|
|
} do
|
|
|
|
|
setup_goals(site)
|
|
|
|
|
lv = get_liveview(conn, site)
|
|
|
|
|
lv |> element(~s/button[phx-click="add-funnel"]/) |> render_click()
|
|
|
|
|
|
|
|
|
|
doc =
|
|
|
|
|
lv
|
|
|
|
|
|> element("form")
|
|
|
|
|
|> render_change(%{funnel: %{name: "My test funnel"}})
|
|
|
|
|
|
|
|
|
|
save_inactive = ~s/form button#save.cursor-not-allowed/
|
|
|
|
|
save_active = ~s/form button#save[type="submit"]/
|
|
|
|
|
|
|
|
|
|
refute element_exists?(doc, save_active)
|
|
|
|
|
assert element_exists?(doc, save_inactive)
|
|
|
|
|
|
|
|
|
|
doc =
|
|
|
|
|
lv
|
|
|
|
|
|> element("form")
|
|
|
|
|
|> render_change(%{
|
|
|
|
|
funnel: %{
|
|
|
|
|
name: "My test funnel",
|
|
|
|
|
steps: [
|
|
|
|
|
%{goal_id: 1},
|
|
|
|
|
%{goal_id: 2}
|
|
|
|
|
]
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
assert element_exists?(doc, save_active)
|
|
|
|
|
refute element_exists?(doc, save_inactive)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
test "cancel buttons renders the funnel list", %{
|
|
|
|
|
conn: conn,
|
|
|
|
|
site: site
|
|
|
|
|
} do
|
|
|
|
|
setup_goals(site)
|
|
|
|
|
lv = get_liveview(conn, site)
|
|
|
|
|
doc = lv |> element(~s/button[phx-click="add-funnel"]/) |> render_click()
|
|
|
|
|
|
|
|
|
|
cancel_button = ~s/button#cancel[phx-click="cancel-add-funnel"]/
|
|
|
|
|
|
|
|
|
|
refute element_exists?(doc, cancel_button)
|
|
|
|
|
|
|
|
|
|
doc =
|
|
|
|
|
lv
|
|
|
|
|
|> element("form")
|
|
|
|
|
|> render_change(%{funnel: %{name: "My test funnel"}})
|
|
|
|
|
|
|
|
|
|
assert element_exists?(doc, cancel_button)
|
|
|
|
|
|
|
|
|
|
doc =
|
|
|
|
|
lv
|
|
|
|
|
|> element(cancel_button)
|
|
|
|
|
|> render_click()
|
|
|
|
|
|
|
|
|
|
assert doc =~ "No funnels configured for this site yet"
|
|
|
|
|
assert element_exists?(doc, ~S/button[phx-click="add-funnel"]/)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
defp setup_funnels(site) do
|
|
|
|
|
{:ok, g1} = Plausible.Goals.create(site, %{"page_path" => "/go/to/blog/**"})
|
|
|
|
|
{:ok, g2} = Plausible.Goals.create(site, %{"event_name" => "Signup"})
|
|
|
|
|
{:ok, [g1, g2]} = setup_goals(site)
|
|
|
|
|
|
|
|
|
|
{:ok, _} =
|
|
|
|
|
Plausible.Funnels.create(
|
|
|
|
|
@ -45,4 +211,29 @@ defmodule PlausibleWeb.FunnelSettingsTest do
|
|
|
|
|
|
|
|
|
|
:ok
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
defp setup_goals(site) do
|
|
|
|
|
{:ok, g1} = Plausible.Goals.create(site, %{"page_path" => "/go/to/blog/**"})
|
|
|
|
|
{:ok, g2} = Plausible.Goals.create(site, %{"event_name" => "Signup"})
|
|
|
|
|
{:ok, [g1, g2]}
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
defp get_liveview(conn, site) do
|
|
|
|
|
conn = assign(conn, :live_module, PlausibleWeb.Live.FunnelSettings)
|
|
|
|
|
{:ok, lv, _html} = live(conn, "/#{site.domain}/settings/funnels")
|
|
|
|
|
lv
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
defp element_exists?(html, selector) do
|
|
|
|
|
html
|
|
|
|
|
|> find(selector)
|
|
|
|
|
|> Enum.empty?()
|
|
|
|
|
|> Kernel.not()
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
defp find(html, value) do
|
|
|
|
|
html
|
|
|
|
|
|> Floki.parse_document!()
|
|
|
|
|
|> Floki.find(value)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|