Remove session length from the UI

pull/23/head
Uku Taht 7 years ago
parent 82ca5b7edc
commit df1ba2cd82

@ -46,15 +46,11 @@ defmodule PlausibleWeb.Api.StatsController do
bounce_rate = Stats.bounce_rate(site, query)
prev_bounce_rate = Stats.bounce_rate(site, prev_query)
change_bounce_rate = if prev_bounce_rate > 0, do: bounce_rate - prev_bounce_rate
session_length = Stats.session_length(site, query)
prev_session_length = Stats.session_length(site, prev_query)
change_session_length = if prev_session_length > 0, do: session_length - prev_session_length
[
%{name: "Unique visitors", count: visitors, change: percent_change(prev_visitors, visitors)},
%{name: "Total pageviews", count: pageviews, change: percent_change(prev_pageviews, pageviews)},
%{name: "Bounce rate", percentage: bounce_rate, change: change_bounce_rate},
%{name: "Session length", duration: session_length, change: change_session_length},
]
end

@ -152,28 +152,6 @@ defmodule PlausibleWeb.Api.StatsController.MainGraphTest do
res = json_response(conn, 200)
assert %{"name" => "Bounce rate", "percentage" => 67, "change" => 17} in res["top_stats"]
end
test "calculates avg session length", %{conn: conn, site: site} do
insert(:session, hostname: site.domain, length: 10, start: ~N[2019-01-01 01:00:00])
insert(:session, hostname: site.domain, length: 20, start: ~N[2019-01-01 02:00:00])
conn = get(conn, "/api/stats/#{site.domain}/main-graph?period=day&date=2019-01-01")
res = json_response(conn, 200)
assert %{"name" => "Session length", "duration" => 15, "change" => nil} in res["top_stats"]
end
test "calculates change in session length", %{conn: conn, site: site} do
insert(:session, hostname: site.domain, length: 10, start: ~N[2019-01-01 01:00:00])
insert(:session, hostname: site.domain, length: 20, start: ~N[2019-01-01 02:00:00])
insert(:session, hostname: site.domain, length: 20, start: ~N[2019-01-02 02:00:00])
conn = get(conn, "/api/stats/#{site.domain}/main-graph?period=day&date=2019-01-02")
res = json_response(conn, 200)
assert %{"name" => "Session length", "duration" => 20, "change" => 5} in res["top_stats"]
end
end

Loading…
Cancel
Save