Commit Graph

9659 Commits (3c00a9e330decc97ab66b217a8495ca4eae06f98)
 

Author SHA1 Message Date
Peter Steinberger 3c00a9e330 perf: remove redundant cli health checks from gateway multi e2e 9 months ago
Artale ab0d8ef8c1
fix(daemon): preserve backslashes in parseCommandLine on Windows (#15642)
* fix(daemon): preserve backslashes in parseCommandLine on Windows

Only treat backslash as escape when followed by a quote or another
backslash. Bare backslashes are kept as-is so Windows paths survive.

Fixes #15587

* fix(daemon): preserve UNC backslashes in schtasks parsing (#15642) (thanks @arosstale)

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
9 months ago
Peter Steinberger 39e6e4cd2c perf: reduce test/runtime overhead in plugin runtime and e2e harness 9 months ago
Peter Steinberger 3cbcba10cf fix(security): enforce bounded webhook body handling 9 months ago
Shadow 2f9c523bbe
CI: run auto-response on label events (#15657) 9 months ago
Tseka Luk 5cd9e210fa
fix(tui): preserve streamed text when final payload regresses (#15452) (#15573)
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: e4a5e3c8a6744249d794e0f553dda3296501a1d1
Co-authored-by: TsekaLuk <79151285+TsekaLuk@users.noreply.github.com>
Co-authored-by: steipete <58493+steipete@users.noreply.github.com>
Reviewed-by: @steipete
9 months ago
Shadow be18f5f0f0
Process: fix Windows exec env overrides 9 months ago
Ross Morsali 6bc6cdad94
fix(nodes-tool): add exec approval flow for agent tool run action (#4726)
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: b8ed4f1b6e4b1363c791dad153bf224b13f87ed3
Co-authored-by: rmorse <853547+rmorse@users.noreply.github.com>
Co-authored-by: steipete <58493+steipete@users.noreply.github.com>
Reviewed-by: @steipete
9 months ago
Peter Steinberger e84318e4bc fix: replace control-char regex with explicit sanitizer 9 months ago
Peter Steinberger 201ac2b72a perf: replace proper-lockfile with lightweight file locks 9 months ago
Tseka Luk c544811559
fix(whatsapp): preserve outbound document filenames (#15594)
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 8e0d765d1d7ebf3375e9d82b27ffeb486c5be930
Co-authored-by: TsekaLuk <79151285+TsekaLuk@users.noreply.github.com>
Co-authored-by: steipete <58493+steipete@users.noreply.github.com>
Reviewed-by: @steipete
9 months ago
Shadow f59df95896
Config: preserve env var references on write (#15600)
* Config: preserve env var references on write

* Config: handle env refs in arrays
9 months ago
Marcus Castro eed8cd383f
fix(agent): search all agent stores when resolving --session-id (#13579)
* fix(agent): search all agent stores when resolving --session-id

When `--session-id` was provided without `--to` or `--agent`, the reverse
lookup only searched the default agent's session store. Sessions created
under a specific agent (e.g. `--agent mybot`) live in that agent's store
file, so the lookup silently failed and the session was not reused.

Now `resolveSessionKeyForRequest` iterates all configured agent stores
when the primary store doesn't contain the requested sessionId.

Fixes #12881

* fix: search other agent stores when --to key does not match --session-id

When --to derives a session key whose stored sessionId doesn't match the
requested --session-id, the cross-store search now also runs. This handles
the case where a user provides both --to and --session-id targeting a
session in a different agent's store.
9 months ago
AI-Reviewer-QS 649826e435
fix(security): block private/loopback/metadata IPs in link-understanding URL detection (#15604)
* fix(security): block private/loopback/metadata IPs in link-understanding URL detection

isAllowedUrl() only blocked 127.0.0.1, leaving localhost, ::1, 0.0.0.0,
private RFC1918 ranges, link-local (169.254.x.x including cloud metadata),
and CGNAT (100.64.0.0/10) accessible for SSRF via link-understanding.

Add comprehensive hostname/IP blocking consistent with the SSRF guard
already used by media/fetch.ts.

* fix(security): harden link-understanding SSRF host checks

* fix: note link-understanding SSRF hardening in changelog (#15604) (thanks @AI-Reviewer-QS)

---------

Co-authored-by: Yi LIU <yi@quantstamp.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
9 months ago
Peter Steinberger fdfc34fa1f perf(test): stabilize e2e harness and reduce flaky gateway coverage 9 months ago
Peter Steinberger 2ab7715d16 docs: clarify auto-install deps recovery workflow 9 months ago
Marcus Castro d91e995e46
fix(inbound): preserve literal backslash-n sequences in Windows paths (#11547)
* fix(inbound): preserve literal backslash-n sequences in Windows paths

The normalizeInboundTextNewlines function was converting literal backslash-n
sequences (\n) to actual newlines, corrupting Windows paths like
C:\Work\nxxx\README.md when sent through WebUI.

This fix removes the .replaceAll("\\n", "\n") operation, preserving
literal backslash-n sequences while still normalizing actual CRLF/CR to LF.

Fixes #7968

* fix(test): set RawBody to Windows path so BodyForAgent fallback chain tests correctly

* fix: tighten Windows path newline regression coverage (#11547) (thanks @mcaxtr)

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
9 months ago
Shadow 684578ecf6
CI: drop trusted label for experienced contributors (#15605) 9 months ago
Marcus Castro 3d921b6157
fix(slack): apply limit parameter to emoji-list action (#13421)
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 67e9b648581c30a6472ac993dcc404e2d104ad1c
Co-authored-by: mcaxtr <7562095+mcaxtr@users.noreply.github.com>
Co-authored-by: steipete <58493+steipete@users.noreply.github.com>
Reviewed-by: @steipete
9 months ago
Mariano Belinky 86e4fe0a7a Auth: land codex oauth onboarding flow (#15406) 9 months ago
Marcus Castro 7ec60d6449 fix: use relayAbort helper for addEventListener to preserve AbortError reason 9 months ago
Marcus Castro 5ac8d1d2bb test: add abort .bind() behavioral tests (#7174) 9 months ago
Marcus Castro d9c582627c perf: use .abort.bind() instead of arrow closures to prevent memory leaks (#7174) 9 months ago
Shadow d637a26350
Gateway: sanitize WebSocket log headers (#15592) 9 months ago
Marcus Castro b3b49bed80
fix(slack): override video/* MIME to audio/* for voice messages (#14941)
* fix(slack): override video/* MIME to audio/* for voice messages

* fix(slack): preserve overridden MIME in return value

* test(slack): fix media monitor MIME mock wiring

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
9 months ago
Shadow 1f4943af3d fix: note Discord guild allowlist resolution (#12326) (thanks @headswim) 9 months ago
headswim f4e295a63b Discord: fix bare guild ID misrouted as channel ID in parser
The channel allowlist parser matches bare numeric strings as channel IDs
before checking for guild IDs, causing guild snowflakes to hit Discord's
/channels/ endpoint (404). Prefix guild-only entries with 'guild:' so the
parser routes them to the correct guild resolution path.

Fixes both the monitor provider and onboarding wizard call sites.
Adds regression tests.
9 months ago
Shadow 5325d2ca51
Discord: gate guild prefix to numeric keys 9 months ago
Lilo 397011bd78
fix: increase image tool maxTokens from 512 to 4096 (#11770)
* increase image tool maxTokens from 512 to 4096

* fix: cap image tool tokens by model capability (#11770) (thanks @detecti1)

* docs: fix changelog attribution for #11770

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
9 months ago
Burak Sormageç 1c36bec970 Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9 months ago
Burak Sormageç ff0ce32840 Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9 months ago
Burak Sormageç 23b1b51568 fix(windows): normalize env entries for spawn 9 months ago
Burak Sormageç e97aa45428 fix(windows): handle undefined environment variables in runCommandWithTimeout 9 months ago
Burak Sormageç d7fb01afad fix(windows): resolve command execution and binary detection issues 9 months ago
Peter Steinberger 1eccfa8934 perf(test): trim duplicate e2e suites and harden signal hooks 9 months ago
Peter Steinberger 45b9aad0f4 fix(imessage): prevent rpc spawn in tests 9 months ago
Peter Steinberger aa7fbf0488 perf(test): trim duplicate sanitize-session-history e2e cases 9 months ago
Peter Steinberger b272158fe4 perf(test): eliminate resetModules via injectable seams 9 months ago
Peter Steinberger a844fb161c build(protocol): regenerate swift gateway models 9 months ago
Yi Liu 14fc742000
fix(security): restrict canvas IP-based auth to private networks (#14661)
Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 9e4e1aca4a89fc4df572681a1146af31b1a3cd50
Co-authored-by: sumleo <29517764+sumleo@users.noreply.github.com>
Co-authored-by: steipete <58493+steipete@users.noreply.github.com>
Reviewed-by: @steipete
9 months ago
Peter Steinberger e665d77917 perf(test): remove extra module resets in cli and message suites 9 months ago
Sk Akram 4c86821aca
fix: allow device-paired clients to retrieve TTS API keys (#14613)
* refactor: add config.get to READ_METHODS set

* refactor(gateway): scope talk secrets via talk.config

* fix: resolve rebase conflicts for talk scope refactor

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
9 months ago
Peter Steinberger c2f7b66d22 perf(test): replace module resets with direct spies and runtime seams 9 months ago
Omair Afzal 59733a02c8
fix(configure): reject literal "undefined" and "null" gateway auth tokens (#13767)
* fix(configure): reject literal "undefined" and "null" gateway auth tokens

* fix(configure): reject literal "undefined" and "null" gateway auth tokens

* fix(configure): validate gateway password prompt and harden token coercion (#13767) (thanks @omair445)

* test: remove unused vitest imports in baseline lint fixtures (#13767)

---------

Co-authored-by: Luna AI <luna@coredirection.ai>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
9 months ago
Peter Steinberger 4dc93f40d5 docs: add git local-branch cleanup fallback 9 months ago
Peter Steinberger 767fd9f222 fix: classify /tools/invoke errors and sanitize 500s (#13185) (thanks @davidrudduck) 9 months ago
David Rudduck 242f2f1480 fix: return 500 for tool execution failures instead of 400
Tool runtime errors are server-side faults, not client input errors.
Returning 400 causes clients to mishandle retries/backoff.

Addresses Greptile review feedback on #13185.
9 months ago
David Rudduck f788de30c8 fix(security): sanitize error responses to prevent information leakage (#5)
* fix(security): sanitize error responses to prevent information leakage

Replace raw error messages in HTTP responses with generic messages.
Internal error details (stack traces, module paths, error messages)
were being returned to clients in 4 gateway endpoints.

* fix: sanitize 2 additional error response leaks in openresponses-http

Address CodeRabbit feedback: non-stream and streaming error paths in
openresponses-http.ts were still returning String(err) to clients.

* fix: add server-side error logging to sanitized catch blocks

Restore err parameter and add logWarn() calls so errors are still
captured server-side for diagnostics while keeping client responses
sanitized. Addresses CodeRabbit feedback about silently discarded errors.
9 months ago
Peter Steinberger de7d94d9e2 perf(test): remove resetModules from config/sandbox/message suites 9 months ago
Peter Steinberger 02fe0c840e perf(test): remove resetModules from auth/models/subagent suites 9 months ago