Update credo config + extras (#3547)

* Disable CyclomaticComplexity checks

* Move AuhtorizeSitesAPI plug under extra
feat/parse-x-vercel-forwarded-for r2023.11.23-259
hq1 3 years ago committed by GitHub
parent 88e1d9dc28
commit 0f577a998c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -116,7 +116,7 @@
# #
{Credo.Check.Refactor.Apply, []}, {Credo.Check.Refactor.Apply, []},
{Credo.Check.Refactor.CondStatements, []}, {Credo.Check.Refactor.CondStatements, []},
{Credo.Check.Refactor.CyclomaticComplexity, []}, {Credo.Check.Refactor.CyclomaticComplexity, false},
{Credo.Check.Refactor.FunctionArity, []}, {Credo.Check.Refactor.FunctionArity, []},
{Credo.Check.Refactor.LongQuoteBlocks, []}, {Credo.Check.Refactor.LongQuoteBlocks, []},
{Credo.Check.Refactor.MatchInCondition, []}, {Credo.Check.Refactor.MatchInCondition, []},

@ -36,7 +36,6 @@ defmodule Plausible.Billing.Plans do
As new versions of plans are introduced, users who were on old plans can As new versions of plans are introduced, users who were on old plans can
still choose from old plans. still choose from old plans.
""" """
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def growth_plans_for(%User{} = user, now \\ Timex.now()) do def growth_plans_for(%User{} = user, now \\ Timex.now()) do
user = Plausible.Users.with_subscription(user) user = Plausible.Users.with_subscription(user)
v4_available = FunWithFlags.enabled?(:business_tier, for: user) v4_available = FunWithFlags.enabled?(:business_tier, for: user)

@ -20,7 +20,6 @@ defmodule Plausible.DataMigration.NumericIDs do
@table_settings "SETTINGS index_granularity = 8192" @table_settings "SETTINGS index_granularity = 8192"
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def run(opts \\ []) do def run(opts \\ []) do
interactive? = Keyword.get(opts, :interactive?, true) interactive? = Keyword.get(opts, :interactive?, true)

@ -353,7 +353,7 @@ defmodule Plausible.Ingestion.Event do
@tablet_types ["car browser", "tablet"] @tablet_types ["car browser", "tablet"]
@desktop_types ["tv", "console", "desktop"] @desktop_types ["tv", "console", "desktop"]
alias UAInspector.Result.Device alias UAInspector.Result.Device
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
defp screen_size(ua) do defp screen_size(ua) do
case ua.device do case ua.device do
%Device{type: t} when t in @mobile_types -> %Device{type: t} when t in @mobile_types ->

@ -71,7 +71,6 @@ defmodule Plausible.Plugins.API.Token do
end end
@spec last_used_humanize(t()) :: String.t() @spec last_used_humanize(t()) :: String.t()
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def last_used_humanize(token) do def last_used_humanize(token) do
diff = diff =
if token.last_used_at do if token.last_used_at do

@ -31,7 +31,6 @@ defmodule Plausible.Stats.Base do
end end
end end
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def query_events(site, query) do def query_events(site, query) do
{first_datetime, last_datetime} = utc_boundaries(query, site) {first_datetime, last_datetime} = utc_boundaries(query, site)
@ -419,7 +418,6 @@ defmodule Plausible.Stats.Base do
|> select_session_metrics(rest, query) |> select_session_metrics(rest, query)
end end
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def dynamic_filter_condition(query, filter_key, db_field) do def dynamic_filter_condition(query, filter_key, db_field) do
case query && query.filters && query.filters[filter_key] do case query && query.filters && query.filters[filter_key] do
{:is, value} -> {:is, value} ->

@ -301,7 +301,6 @@ defmodule Plausible.Stats.Clickhouse do
end end
end end
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
defp base_session_query(site, query) do defp base_session_query(site, query) do
{first_datetime, last_datetime} = utc_boundaries(query, site) {first_datetime, last_datetime} = utc_boundaries(query, site)
@ -421,7 +420,6 @@ defmodule Plausible.Stats.Clickhouse do
end end
end end
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
defp base_query_bare(site, query) do defp base_query_bare(site, query) do
{first_datetime, last_datetime} = utc_boundaries(query, site) {first_datetime, last_datetime} = utc_boundaries(query, site)

@ -177,7 +177,6 @@ defmodule Plausible.Stats.FilterSuggestions do
|> wrap_suggestions() |> wrap_suggestions()
end end
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def filter_suggestions(site, query, filter_name, filter_search) do def filter_suggestions(site, query, filter_name, filter_search) do
filter_search = if filter_search == nil, do: "", else: filter_search filter_search = if filter_search == nil, do: "", else: filter_search

@ -54,7 +54,6 @@ defmodule Plausible.Stats.Filters do
end end
@non_escaped_pipe_regex ~r/(?<!\\)\|/ @non_escaped_pipe_regex ~r/(?<!\\)\|/
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
defp filter_value(key, val) do defp filter_value(key, val) do
{is_negated, val} = parse_negated_prefix(val) {is_negated, val} = parse_negated_prefix(val)
{is_contains, val} = parse_contains_prefix(val) {is_contains, val} = parse_contains_prefix(val)

@ -56,7 +56,6 @@ defmodule Plausible.Stats.Imported do
# GA only has 'source' # GA only has 'source'
def merge_imported(q, _, _, "utm_source", _), do: q def merge_imported(q, _, _, "utm_source", _), do: q
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def merge_imported(q, site, query, property, metrics) def merge_imported(q, site, query, property, metrics)
when property in [ when property in [
"visit:source", "visit:source",

@ -226,7 +226,6 @@ defmodule Plausible.Stats.Timeseries do
end end
end end
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
defp empty_row(date, metrics) do defp empty_row(date, metrics) do
Enum.reduce(metrics, %{date: date}, fn metric, row -> Enum.reduce(metrics, %{date: date}, fn metric, row ->
case metric do case metric do

@ -15,7 +15,6 @@ defmodule PlausibleWeb.Components.Billing do
attr(:size, :atom, default: :sm) attr(:size, :atom, default: :sm)
attr(:rest, :global) attr(:rest, :global)
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def premium_feature_notice(assigns) do def premium_feature_notice(assigns) do
~H""" ~H"""
<.notice <.notice
@ -37,7 +36,6 @@ defmodule PlausibleWeb.Components.Billing do
attr(:resource, :string, required: true) attr(:resource, :string, required: true)
attr(:rest, :global) attr(:rest, :global)
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
def limit_exceeded_notice(assigns) do def limit_exceeded_notice(assigns) do
~H""" ~H"""
<.notice {@rest} title="Notice"> <.notice {@rest} title="Notice">

@ -627,7 +627,6 @@ defmodule PlausibleWeb.Live.ChoosePlan do
""" """
end end
# credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
defp change_plan_link_text( defp change_plan_link_text(
%{ %{
owned_plan: %Plan{kind: from_kind, monthly_pageview_limit: from_volume}, owned_plan: %Plan{kind: from_kind, monthly_pageview_limit: from_volume},

Loading…
Cancel
Save